Commit Graph

67 Commits

Author SHA1 Message Date
richestrinh
96b7af5988
build: ESLint rule to check/add license headers (#11716) 2024-01-27 06:25:39 +01:00
Nikolay Vitkov
35e39bfae9
chore: fix EsLint for .mjs (#11629) 2024-01-08 10:02:56 +01:00
Nikolay Vitkov
b6c5642cc9
chore: update license headers (#11563) 2024-01-03 10:11:33 +00:00
Nikolay Vitkov
42b03a67d0
chore: enable no-useless-template-literals rule (#11573) 2024-01-02 12:35:01 +00:00
Nikolay Vitkov
4805417a64
chore: update smoke.mjs for ng-schematics (#11544) 2023-12-18 14:55:52 +00:00
Nikolay Vitkov
619d9d0262
chore: fix RxJs import for BiDi (#11299) 2023-11-06 06:58:20 +01:00
Alex Rudenko
954c75f9a9
fix: remove import cycle in query handlers (#11234) 2023-10-23 15:21:48 +00:00
Alex Rudenko
014c72ae1d
chore: merge locators in a single file (#11233) 2023-10-23 12:23:46 +00:00
Alex Rudenko
b9ce89e460
fix: remove more import cycles (#11231) 2023-10-23 14:06:41 +02:00
Nikolay Vitkov
443ee99a8d
chore: fix RxJS import (#11176) 2023-10-17 08:30:04 +00:00
jrandolf
bd6c246b18
chore: add @typescript-eslint/no-import-type-side-effects (#11040) 2023-09-26 18:24:24 +02:00
jrandolf
d124c83dad
chore: rename mocha-runner (#10984) 2023-09-22 10:57:18 +02:00
Alex Rudenko
02a9917d16
test: detect dependency cycles (#10973) 2023-09-21 22:22:38 +02:00
jrandolf
ecd6ac9dfa
chore: implement element screenshot (#10963) 2023-09-21 21:21:12 +02:00
jrandolf
c949656a43
chore: use @typescript-eslint/consistent-type-imports (#10913) 2023-09-15 13:00:20 +02:00
jrandolf
7e74439c51
chore: enable 'return-await` (#10832) 2023-09-01 09:49:33 +02:00
jrandolf
900a1f227d
chore: turn on rulesdir/use-using (#10806) 2023-08-30 10:02:59 +00:00
jrandolf
dca327f99f
chore: implement use-using rule (#10798) 2023-08-29 19:41:29 +00:00
jrandolf
a4a2cf1d39
chore: update dependencies (#10781) 2023-08-24 14:42:51 +02:00
Nikolay Vitkov
de09b058ba
chore: update Prettier and other deps (#10555) 2023-07-17 10:52:54 +02:00
Alex Rudenko
c35084dd2c
ci: separate unit tests (#10436) 2023-06-26 10:57:48 +02:00
Nikolay Vitkov
9abd48a062
fix: content() not showing comments outside html tag (#10293) 2023-06-01 21:51:16 +02:00
Nikolay Vitkov
39e9737232
refactor: Deferred to a class (#10282) 2023-05-31 23:36:19 +02:00
Nikolay Vitkov
e4b57c279a
chore: add EsLint rule for no-floating-promises (#10084) 2023-04-26 09:53:02 +00:00
Nikolay Vitkov
eefe9583d0
chore: Add EsLint rule import/order (#9685) 2023-02-15 15:09:31 -08:00
jrandolf
2a21896cf8
chore: rename vendor to third_party (#9021)
This PR renames `vendor` to `third_party` to better adhere to internal
codebase nomenclature.
2022-09-28 15:23:37 +02:00
jrandolf
f8de7b1273
chore: bundle vendor code (#9016)
This PR removes the manual vendoring process. Third party code can now
be updated using the typical NPM pipeline with types/code bundling done
through Rollup.
2022-09-28 13:03:19 +02:00
jrandolf
ddbe88b887
chore: add custom rule for formatting comments (#8777) 2022-08-12 14:15:26 +02:00
jrandolf
5ff205dc8b
fix: extends ElementHandle to Nodes (#8552)
* fix: extends `ElementHandle` to `Node`s (#8552)
2022-07-06 09:05:37 +02:00
jrandolf
84712cbc28
chore: use Google's TS style guide's format config (#8542) 2022-06-22 15:25:44 +02:00
jrandolf
ce0dd25349
chore: use braces in function bodies (#8525) 2022-06-15 12:42:21 +02:00
jrandolf
e6442dd767
chore: use curly (#8519) 2022-06-14 13:55:35 +02:00
jrandolf
0678343b53
chore: move helper.js to util.js (#8510) 2022-06-14 13:16:21 +02:00
jrandolf
6c960115a3
chore: use private fields (#8506) 2022-06-13 11:16:25 +02:00
jrandolf
75c3f94a54
chore: namespace commands (#8494) 2022-06-10 11:55:53 +02:00
jrandolf
30438e6532
chore: use ts-doc and factor out importFSModule (#8449) 2022-06-01 11:11:09 +02:00
Alex Rudenko
256223a7b1
chore: strict-mode TS for DOMWorld (#8398) 2022-05-25 15:34:11 +02:00
Mathias Bynens
686030fe0d
chore: remove references to upstream master branches (#7412)
Chromium had its branch renamed to `main`, and for other projects we can just point to the `HEAD`.
2021-09-14 15:02:39 +00:00
Jack Franklin
3204f2780f
chore: fix eslint warnings around type defs (#7230)
This PR updates some code to remove constant ESLint warnings. It also
upgrades those warnings to errors - so that they have to be resolved
as part of the PR, rather than landing as a warning and causing noise.

Fixes #7229.
2021-05-12 17:43:05 +01:00
Jack Franklin
f04bec5a15
chore: update eslint & eslint plugins (#6487)
Updates ESLint, the TypeScript ESLint plugins, and updates code where
the rules have changed.
2020-10-12 10:30:35 +01:00
Lars den Bakker
15d1906e7c
feat: add web test runner (#6200) 2020-07-22 13:14:35 +02:00
Jack Franklin
f1a6b8d66d
chore: vendor Mitt & update project structure (#6209)
* chore: vendor Mitt into src/common/third-party

As discussed in #6203 we need to vendor our common dependencies in so
that when we ship an ESM build all imports point to file paths and do
not rely on Node resolution (e.g. a browser does not understand `import
mitt from 'mitt'`).
2020-07-14 16:57:29 +01:00
Jack Franklin
ffec2475d0
chore: enforce file extensions on imports (#6202)
* chore: enforce file extensions on imports

To make our output agnostic it should include file extensions in the
output, as per the ESM spec. It's a bit odd for Node packages but makes
it easier to publish a browser build.
2020-07-13 10:22:26 +01:00
Jack Franklin
19f188a852
chore: forbid importing src/common/Events.ts (#6183)
This file is now deprecated and only used by the coverage tool and
DocLint - these tools will be updated to not rely on it in the future.

We now have events defined per class - e.g. all the events that `Page`
can emit are defined in the `PageEmittedEvents` enum, and similar. We
have to keep `Events.ts` around for the aforementioned tools, but don't
want its usage creeping back into our source code.
2020-07-08 16:03:16 +01:00
Jack Franklin
46fc6ca41a
feat(types): improve typing of .evaluate() (#6096)
* feat(types): improve typing of `.evaluate()`

This is the start of the work to take the types from the
`@types/puppeteer` repository and port them into our repo so we can ship
our built-in types out the box.

This change types the `evaluate` function properly. It takes a generic
type which is the type of the function you're passing, and the arguments
and the return that you get back from the `evaluate` call are typed
correctly.
2020-06-25 13:38:01 +01:00
Jack Franklin
70a900e93b
chore: fix ESLint violation and lessen rule strictness (#6081) 2020-06-23 12:55:42 +01:00
Jack Franklin
e7b91a7f41
chore: enforce a max line length on comments (#6055) 2020-06-19 15:39:03 +01:00
Jack Franklin
4fdb1e3cab
chore: add Prettier (#5825) 2020-05-07 12:54:55 +02:00
Jack Franklin
d69fbb9974
chore: Enforce array type styles in TypeScript (#5765)
This change enforces how we type arrays, e.g. choosing between:

* `string[]`
* `Array<string>`

I've gone for the `array-simple` option [1] which enforces that:

* primitive types and type references use `X[]`
* complex types use `Array<X>`

For example, we'd type an array of strings as `string[]`, but an array
of a union type as `Array<SomeUnionType>`.

[1]: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/array-type.md
2020-04-28 15:06:43 +01:00
Jack Franklin
1ccfbcb684
chore: enforce naming of errors in catch blocks (#5763) 2020-04-28 15:16:28 +02:00