mirror of
https://github.com/puppeteer/puppeteer
synced 2024-06-14 14:02:48 +00:00
3e80667048
<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. --> **What kind of change does this PR introduce?** types fix **Did you add tests for your changes?** No **If relevant, did you update the documentation?** Not relevant **Summary** I am updating `import`s of `devtools-protocol` to always use named import instead of the default. For some reason, typescript doesn't understand when it is imported as default. ``` node_modules/puppeteer-core/lib/esm/puppeteer/common/TargetManager.d.ts:23:59 - error TS2694: Namespace '"/Users/kyrylo/pacakge/node_modules/puppeteer-core/node_modules/devtools-protocol/types/protocol"' has no exported member 'Target'. 23 export declare type TargetFactory = (targetInfo: Protocol.Target.TargetInfo, session?: CDPSession) => Target; ~~~~~~ Found 1 error in node_modules/puppeteer-core/lib/esm/puppeteer/common/TargetManager.d.ts:23 ``` **Does this PR introduce a breaking change?** No <!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. --> **Other information** I am updating `import`s of `devtools-protocol` to always use named import instead of the default. |
||
---|---|---|
.. | ||
src | ||
third_party | ||
tools | ||
.gitignore | ||
api-extractor.json | ||
CHANGELOG.md | ||
package.json | ||
rollup.third_party.config.js | ||
tsconfig.json |