puppeteer/test/src/keyboard.spec.ts
jrandolf 26c3acbb07
feat!: type inference for evaluation types (#8547)
This PR greatly improves the types within Puppeteer:

- **Almost everything** is auto-deduced.
  - Parameters don't need to be specified in the function. They are deduced from the spread.
  - Return types don't need to be specified. They are deduced from the function. (More on this below)
  - Selections based on tag names correctly deduce element type, similar to TypeScript's mechanism for `getElementByTagName`.
- [**BREAKING CHANGE**] We've removed the ability to declare return types in type arguments for the following reasons:
  1. Setting them will indubitably break auto-deduction.
  2. You can just use `as ...` in TypeScript to coerce the correct type (given it makes sense).
- [**BREAKING CHANGE**] `waitFor` is officially gone.

To migrate to these changes, there are only four things you may need to change:
- If you set a return type using the `ReturnType` type parameter, remove it and use `as ...` and `HandleFor` (if necessary).
 `evaluate<ReturnType>(a: number, b: number) => {...}, a, b)`
 `(await evaluate(a, b) => {...}, a, b)) as ReturnType`
 `evaluateHandle<ReturnType>(a: number, b: number) => {...}, a, b)`
 `(await evaluateHandle(a, b) => {...}, a, b)) as HandleFor<ReturnType>`
- If you set any type parameters in the *parameters* of an evaluation function, remove them.  
 `evaluate(a: number, b: number) => {...}, a, b)`
 `evaluate(a, b) => {...}, a, b)`
- If you set any type parameters in the method's declaration, remove them.
 `evaluate<(a: number, b: number) => void>((a, b) => {...}, a, b)`
 `evaluate(a, b) => {...}, a, b)`
2022-06-23 11:29:46 +02:00

530 lines
15 KiB
TypeScript

/**
* Copyright 2018 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import utils from './utils.js';
import os from 'os';
import expect from 'expect';
import {
getTestState,
setupTestBrowserHooks,
setupTestPageAndContextHooks,
itFailsFirefox,
} from './mocha-utils.js';
import {KeyInput} from '../../lib/cjs/puppeteer/common/USKeyboardLayout.js';
describe('Keyboard', function () {
setupTestBrowserHooks();
setupTestPageAndContextHooks();
it('should type into a textarea', async () => {
const {page} = getTestState();
await page.evaluate(() => {
const textarea = document.createElement('textarea');
document.body.appendChild(textarea);
textarea.focus();
});
const text = 'Hello world. I am the text that was typed!';
await page.keyboard.type(text);
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe(text);
});
itFailsFirefox('should press the metaKey', async () => {
const {page, isFirefox} = getTestState();
await page.evaluate(() => {
(window as any).keyPromise = new Promise(resolve => {
return document.addEventListener('keydown', event => {
return resolve(event.key);
});
});
});
await page.keyboard.press('Meta');
expect(await page.evaluate('keyPromise')).toBe(
isFirefox && os.platform() !== 'darwin' ? 'OS' : 'Meta'
);
});
it('should move with the arrow keys', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
await page.type('textarea', 'Hello World!');
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe('Hello World!');
for (let i = 0; i < 'World!'.length; i++) {
page.keyboard.press('ArrowLeft');
}
await page.keyboard.type('inserted ');
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe('Hello inserted World!');
page.keyboard.down('Shift');
for (let i = 0; i < 'inserted '.length; i++) {
page.keyboard.press('ArrowLeft');
}
page.keyboard.up('Shift');
await page.keyboard.press('Backspace');
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe('Hello World!');
});
it('should send a character with ElementHandle.press', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
const textarea = (await page.$('textarea'))!;
await textarea.press('a');
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe('a');
await page.evaluate(() => {
return window.addEventListener(
'keydown',
e => {
return e.preventDefault();
},
true
);
});
await textarea.press('b');
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe('a');
});
itFailsFirefox(
'ElementHandle.press should support |text| option',
async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
const textarea = (await page.$('textarea'))!;
await textarea.press('a', {text: 'ё'});
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe('ё');
}
);
itFailsFirefox('should send a character with sendCharacter', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
await page.focus('textarea');
await page.keyboard.sendCharacter('嗨');
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe('嗨');
await page.evaluate(() => {
return window.addEventListener(
'keydown',
e => {
return e.preventDefault();
},
true
);
});
await page.keyboard.sendCharacter('a');
expect(
await page.evaluate(() => {
return document.querySelector('textarea')!.value;
})
).toBe('嗨a');
});
itFailsFirefox('should report shiftKey', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/keyboard.html');
const keyboard = page.keyboard;
const codeForKey = new Map<KeyInput, number>([
['Shift', 16],
['Alt', 18],
['Control', 17],
]);
for (const [modifierKey, modifierCode] of codeForKey) {
await keyboard.down(modifierKey);
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe(
'Keydown: ' +
modifierKey +
' ' +
modifierKey +
'Left ' +
modifierCode +
' [' +
modifierKey +
']'
);
await keyboard.down('!');
// Shift+! will generate a keypress
if (modifierKey === 'Shift') {
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe(
'Keydown: ! Digit1 49 [' +
modifierKey +
']\nKeypress: ! Digit1 33 33 [' +
modifierKey +
']'
);
} else {
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe('Keydown: ! Digit1 49 [' + modifierKey + ']');
}
await keyboard.up('!');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe('Keyup: ! Digit1 49 [' + modifierKey + ']');
await keyboard.up(modifierKey);
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe(
'Keyup: ' +
modifierKey +
' ' +
modifierKey +
'Left ' +
modifierCode +
' []'
);
}
});
it('should report multiple modifiers', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/keyboard.html');
const keyboard = page.keyboard;
await keyboard.down('Control');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe('Keydown: Control ControlLeft 17 [Control]');
await keyboard.down('Alt');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe('Keydown: Alt AltLeft 18 [Alt Control]');
await keyboard.down(';');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe('Keydown: ; Semicolon 186 [Alt Control]');
await keyboard.up(';');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe('Keyup: ; Semicolon 186 [Alt Control]');
await keyboard.up('Control');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe('Keyup: Control ControlLeft 17 [Alt]');
await keyboard.up('Alt');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe('Keyup: Alt AltLeft 18 []');
});
it('should send proper codes while typing', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/keyboard.html');
await page.keyboard.type('!');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe(
[
'Keydown: ! Digit1 49 []',
'Keypress: ! Digit1 33 33 []',
'Keyup: ! Digit1 49 []',
].join('\n')
);
await page.keyboard.type('^');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe(
[
'Keydown: ^ Digit6 54 []',
'Keypress: ^ Digit6 94 94 []',
'Keyup: ^ Digit6 54 []',
].join('\n')
);
});
it('should send proper codes while typing with shift', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/keyboard.html');
const keyboard = page.keyboard;
await keyboard.down('Shift');
await page.keyboard.type('~');
expect(
await page.evaluate(() => {
return (globalThis as any).getResult();
})
).toBe(
[
'Keydown: Shift ShiftLeft 16 [Shift]',
'Keydown: ~ Backquote 192 [Shift]', // 192 is ` keyCode
'Keypress: ~ Backquote 126 126 [Shift]', // 126 is ~ charCode
'Keyup: ~ Backquote 192 [Shift]',
].join('\n')
);
await keyboard.up('Shift');
});
it('should not type canceled events', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
await page.focus('textarea');
await page.evaluate(() => {
window.addEventListener(
'keydown',
event => {
event.stopPropagation();
event.stopImmediatePropagation();
if (event.key === 'l') {
event.preventDefault();
}
if (event.key === 'o') {
event.preventDefault();
}
},
false
);
});
await page.keyboard.type('Hello World!');
expect(
await page.evaluate(() => {
return (globalThis as any).textarea.value;
})
).toBe('He Wrd!');
});
itFailsFirefox('should specify repeat property', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
await page.focus('textarea');
await page.evaluate(() => {
return document.querySelector('textarea')!.addEventListener(
'keydown',
e => {
return ((globalThis as any).lastEvent = e);
},
true
);
});
await page.keyboard.down('a');
expect(
await page.evaluate(() => {
return (globalThis as any).lastEvent.repeat;
})
).toBe(false);
await page.keyboard.press('a');
expect(
await page.evaluate(() => {
return (globalThis as any).lastEvent.repeat;
})
).toBe(true);
await page.keyboard.down('b');
expect(
await page.evaluate(() => {
return (globalThis as any).lastEvent.repeat;
})
).toBe(false);
await page.keyboard.down('b');
expect(
await page.evaluate(() => {
return (globalThis as any).lastEvent.repeat;
})
).toBe(true);
await page.keyboard.up('a');
await page.keyboard.down('a');
expect(
await page.evaluate(() => {
return (globalThis as any).lastEvent.repeat;
})
).toBe(false);
});
itFailsFirefox('should type all kinds of characters', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
await page.focus('textarea');
const text = 'This text goes onto two lines.\nThis character is 嗨.';
await page.keyboard.type(text);
expect(await page.evaluate('result')).toBe(text);
});
itFailsFirefox('should specify location', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
await page.evaluate(() => {
window.addEventListener(
'keydown',
event => {
return ((globalThis as any).keyLocation = event.location);
},
true
);
});
const textarea = (await page.$('textarea'))!;
await textarea.press('Digit5');
expect(await page.evaluate('keyLocation')).toBe(0);
await textarea.press('ControlLeft');
expect(await page.evaluate('keyLocation')).toBe(1);
await textarea.press('ControlRight');
expect(await page.evaluate('keyLocation')).toBe(2);
await textarea.press('NumpadSubtract');
expect(await page.evaluate('keyLocation')).toBe(3);
});
it('should throw on unknown keys', async () => {
const {page} = getTestState();
let error = await page.keyboard
// @ts-expect-error bad input
.press('NotARealKey')
.catch(error_ => {
return error_;
});
expect(error.message).toBe('Unknown key: "NotARealKey"');
// @ts-expect-error bad input
error = await page.keyboard.press('ё').catch(error_ => {
return error_;
});
expect(error && error.message).toBe('Unknown key: "ё"');
// @ts-expect-error bad input
error = await page.keyboard.press('😊').catch(error_ => {
return error_;
});
expect(error && error.message).toBe('Unknown key: "😊"');
});
itFailsFirefox('should type emoji', async () => {
const {page, server} = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
await page.type('textarea', '👹 Tokyo street Japan 🇯🇵');
expect(
await page.$eval('textarea', textarea => {
return textarea.value;
})
).toBe('👹 Tokyo street Japan 🇯🇵');
});
itFailsFirefox('should type emoji into an iframe', async () => {
const {page, server} = getTestState();
await page.goto(server.EMPTY_PAGE);
await utils.attachFrame(
page,
'emoji-test',
server.PREFIX + '/input/textarea.html'
);
const frame = page.frames()[1]!;
const textarea = (await frame.$('textarea'))!;
await textarea.type('👹 Tokyo street Japan 🇯🇵');
expect(
await frame.$eval('textarea', textarea => {
return textarea.value;
})
).toBe('👹 Tokyo street Japan 🇯🇵');
});
itFailsFirefox('should press the meta key', async () => {
const {page, isFirefox} = getTestState();
await page.evaluate(() => {
(globalThis as any).result = null;
document.addEventListener('keydown', event => {
(globalThis as any).result = [event.key, event.code, event.metaKey];
});
});
await page.keyboard.press('Meta');
// Have to do this because we lose a lot of type info when evaluating a
// string not a function. This is why functions are recommended rather than
// using strings (although we'll leave this test so we have coverage of both
// approaches.)
const [key, code, metaKey] = (await page.evaluate('result')) as [
string,
string,
boolean
];
if (isFirefox && os.platform() !== 'darwin') {
expect(key).toBe('OS');
} else {
expect(key).toBe('Meta');
}
if (isFirefox) {
expect(code).toBe('OSLeft');
} else {
expect(code).toBe('MetaLeft');
}
if (isFirefox && os.platform() !== 'darwin') {
expect(metaKey).toBe(false);
} else {
expect(metaKey).toBe(true);
}
});
});