mirror of
https://github.com/puppeteer/puppeteer
synced 2024-06-14 14:02:48 +00:00
0bea42bd8c
It's very bad to have 'unhandled promise rejection' that can't be handled in user code. These errors will exit node process in a near future. This patch avoids 'unhandled promise rejection' while sending protocol messages. This patch: - introduces `puppeteer:error` debug scope and starts using it for all swalloed errors. - makes sure that every `client.send` method is either awaited or its errors are handled. - starts return promises from Request.continue() and Request.abort(). - starts swallow errors from Request.contine() and Request.abort(). The last is the most important part of the patch. Since `Request.continue()` might try to continue canceled request, we should disregard the error. Fixes #627.
81 lines
2.0 KiB
JavaScript
81 lines
2.0 KiB
JavaScript
/**
|
|
* Copyright 2017 Google Inc. All rights reserved.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
const {helper} = require('./helper');
|
|
const Page = require('./Page');
|
|
|
|
class Browser {
|
|
/**
|
|
* @param {!Connection} connection
|
|
* @param {boolean} ignoreHTTPSErrors
|
|
* @param {function()=} closeCallback
|
|
*/
|
|
constructor(connection, ignoreHTTPSErrors, closeCallback) {
|
|
this._ignoreHTTPSErrors = ignoreHTTPSErrors;
|
|
this._screenshotTaskQueue = new TaskQueue();
|
|
this._connection = connection;
|
|
this._closeCallback = closeCallback || new Function();
|
|
}
|
|
|
|
/**
|
|
* @return {string}
|
|
*/
|
|
wsEndpoint() {
|
|
return this._connection.url();
|
|
}
|
|
|
|
/**
|
|
* @return {!Promise<!Page>}
|
|
*/
|
|
async newPage() {
|
|
const {targetId} = await this._connection.send('Target.createTarget', {url: 'about:blank'});
|
|
const client = await this._connection.createSession(targetId);
|
|
return await Page.create(client, this._ignoreHTTPSErrors, this._screenshotTaskQueue);
|
|
}
|
|
|
|
/**
|
|
* @return {!Promise<string>}
|
|
*/
|
|
async version() {
|
|
const version = await this._connection.send('Browser.getVersion');
|
|
return version.product;
|
|
}
|
|
|
|
close() {
|
|
this._connection.dispose();
|
|
this._closeCallback.call(null);
|
|
}
|
|
}
|
|
|
|
module.exports = Browser;
|
|
helper.tracePublicAPI(Browser);
|
|
|
|
class TaskQueue {
|
|
constructor() {
|
|
this._chain = Promise.resolve();
|
|
}
|
|
|
|
/**
|
|
* @param {function()} task
|
|
* @return {!Promise}
|
|
*/
|
|
postTask(task) {
|
|
const result = this._chain.then(task);
|
|
this._chain = result.catch(() => {});
|
|
return result;
|
|
}
|
|
}
|