mirror of
https://github.com/puppeteer/puppeteer
synced 2024-06-14 14:02:48 +00:00
e0c8d46af1
We'd like to pass an abortion signal inside Helper.waitForEvent in order to interrupt it when browser/page closes. Several approaches have been considered: 1. Pass CDPSession instance as a another parameter to the helper method and listen to Disconnected event on it. It would introduce undesired dependency on the session object. 2. Listen to the CDPSession closure at the call sites (e.g. waitForRequest) and pass an abortion promise which would be fulfilled when such event is fired. The listeners would have to be removed from the session on successful completion of waitForEvent so we'd have to pass some kind of DisposablePromise which would be disposed during cleanup. Such parameter looked somewhat hairy. 3. Create DisconnectPromise on CDPSession. One potential risk with that is all chained promises would hang around until the event is fired which might inadvertently cause memory leaks. On the other hand, adding such promise to Promise.race will remove dependency as soon as the race is finished. So this is the approach we're taking with one tweak: the promise is created locally inside Page. Ideally the disconnectPromise would throw when the session is closed but it may lead to uncaught promise errors if all chained promises are resolved, to avoid that the promise is resolved with an Error and Helper.waitForEvent throws it later. Fix #4733 |
||
|---|---|---|
| .. | ||
| assets | ||
| fixtures | ||
| golden-chromium | ||
| golden-firefox | ||
| accessibility.spec.js | ||
| browser.spec.js | ||
| browsercontext.spec.js | ||
| CDPSession.spec.js | ||
| chromiumonly.spec.js | ||
| click.spec.js | ||
| cookies.spec.js | ||
| coverage.spec.js | ||
| defaultbrowsercontext.spec.js | ||
| dialog.spec.js | ||
| diffstyle.css | ||
| elementhandle.spec.js | ||
| emulation.spec.js | ||
| evaluation.spec.js | ||
| fixtures.spec.js | ||
| frame.spec.js | ||
| golden-utils.js | ||
| headful.spec.js | ||
| ignorehttpserrors.spec.js | ||
| input.spec.js | ||
| jshandle.spec.js | ||
| keyboard.spec.js | ||
| launcher.spec.js | ||
| mouse.spec.js | ||
| navigation.spec.js | ||
| network.spec.js | ||
| oopif.spec.js | ||
| page.spec.js | ||
| puppeteer.spec.js | ||
| queryselector.spec.js | ||
| requestinterception.spec.js | ||
| run_static_server.js | ||
| screenshot.spec.js | ||
| target.spec.js | ||
| test.js | ||
| touchscreen.spec.js | ||
| tracing.spec.js | ||
| utils.js | ||
| waittask.spec.js | ||
| worker.spec.js | ||