mirror of
https://github.com/puppeteer/puppeteer
synced 2024-06-14 14:02:48 +00:00
067662c677
In puppeteer 1.20.0, the following code emitted an alert:
```
const puppeteer = require('puppeteer');
(async () => {
const browser = await puppeteer.launch({args: ['--no-sandbox'], headless: false});
const page = (await browser.pages())[0];
await page.setContent(`
<input type=file>
<script>
document.querySelector('input').addEventListener('change', () => {
alert('Uploaded a file');
});
</script>
`);
const input = await page.waitForSelector('input[type="file"]');
await input.uploadFile(__filename);
})();
```
A bisection yielded 6091a34a36
as the commit that broke this.
Emitting the change event as well seems to fix the problem.
230 lines
9.3 KiB
JavaScript
230 lines
9.3 KiB
JavaScript
/**
|
|
* Copyright 2017 Google Inc. All rights reserved.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
const path = require('path');
|
|
|
|
const FILE_TO_UPLOAD = path.join(__dirname, '/assets/file-to-upload.txt');
|
|
|
|
module.exports.addTests = function({testRunner, expect, puppeteer}) {
|
|
const {describe, xdescribe, fdescribe, describe_fails_ffox} = testRunner;
|
|
const {it, fit, xit, it_fails_ffox} = testRunner;
|
|
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
|
|
describe_fails_ffox('input', function() {
|
|
it('should upload the file', async({page, server}) => {
|
|
await page.goto(server.PREFIX + '/input/fileupload.html');
|
|
const filePath = path.relative(process.cwd(), FILE_TO_UPLOAD);
|
|
const input = await page.$('input');
|
|
await page.evaluate(e => {
|
|
window._inputEvents = [];
|
|
e.addEventListener('change', ev => window._inputEvents.push(ev.type));
|
|
e.addEventListener('input', ev => window._inputEvents.push(ev.type));
|
|
}, input);
|
|
await input.uploadFile(filePath);
|
|
expect(await page.evaluate(e => e.files[0].name, input)).toBe('file-to-upload.txt');
|
|
expect(await page.evaluate(() => window._inputEvents)).toEqual(['input', 'change']);
|
|
expect(await page.evaluate(e => {
|
|
const reader = new FileReader();
|
|
const promise = new Promise(fulfill => reader.onload = fulfill);
|
|
reader.readAsText(e.files[0]);
|
|
return promise.then(() => reader.result);
|
|
}, input)).toBe('contents of the file');
|
|
});
|
|
});
|
|
|
|
describe_fails_ffox('Page.waitForFileChooser', function() {
|
|
it('should work when file input is attached to DOM', async({page, server}) => {
|
|
await page.setContent(`<input type=file>`);
|
|
const [chooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.click('input'),
|
|
]);
|
|
expect(chooser).toBeTruthy();
|
|
});
|
|
it('should work when file input is not attached to DOM', async({page, server}) => {
|
|
const [chooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.evaluate(() => {
|
|
const el = document.createElement('input');
|
|
el.type = 'file';
|
|
el.click();
|
|
}),
|
|
]);
|
|
expect(chooser).toBeTruthy();
|
|
});
|
|
it('should respect timeout', async({page, server}) => {
|
|
let error = null;
|
|
await page.waitForFileChooser({timeout: 1}).catch(e => error = e);
|
|
expect(error).toBeInstanceOf(puppeteer.errors.TimeoutError);
|
|
});
|
|
it('should respect default timeout when there is no custom timeout', async({page, server}) => {
|
|
page.setDefaultTimeout(1);
|
|
let error = null;
|
|
await page.waitForFileChooser().catch(e => error = e);
|
|
expect(error).toBeInstanceOf(puppeteer.errors.TimeoutError);
|
|
});
|
|
it('should prioritize exact timeout over default timeout', async({page, server}) => {
|
|
page.setDefaultTimeout(0);
|
|
let error = null;
|
|
await page.waitForFileChooser({timeout: 1}).catch(e => error = e);
|
|
expect(error).toBeInstanceOf(puppeteer.errors.TimeoutError);
|
|
});
|
|
it('should work with no timeout', async({page, server}) => {
|
|
const [chooser] = await Promise.all([
|
|
page.waitForFileChooser({timeout: 0}),
|
|
page.evaluate(() => setTimeout(() => {
|
|
const el = document.createElement('input');
|
|
el.type = 'file';
|
|
el.click();
|
|
}, 50))
|
|
]);
|
|
expect(chooser).toBeTruthy();
|
|
});
|
|
it('should return the same file chooser when there are many watchdogs simultaneously', async({page, server}) => {
|
|
await page.setContent(`<input type=file>`);
|
|
const [fileChooser1, fileChooser2] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.waitForFileChooser(),
|
|
page.$eval('input', input => input.click()),
|
|
]);
|
|
expect(fileChooser1 === fileChooser2).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe_fails_ffox('FileChooser.accept', function() {
|
|
it('should accept single file', async({page, server}) => {
|
|
await page.setContent(`<input type=file oninput='javascript:console.timeStamp()'>`);
|
|
const [chooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.click('input'),
|
|
]);
|
|
await Promise.all([
|
|
chooser.accept([FILE_TO_UPLOAD]),
|
|
new Promise(x => page.once('metrics', x)),
|
|
]);
|
|
expect(await page.$eval('input', input => input.files.length)).toBe(1);
|
|
expect(await page.$eval('input', input => input.files[0].name)).toBe('file-to-upload.txt');
|
|
});
|
|
it('should be able to read selected file', async({page, server}) => {
|
|
await page.setContent(`<input type=file>`);
|
|
page.waitForFileChooser().then(chooser => chooser.accept([FILE_TO_UPLOAD]));
|
|
expect(await page.$eval('input', async picker => {
|
|
picker.click();
|
|
await new Promise(x => picker.oninput = x);
|
|
const reader = new FileReader();
|
|
const promise = new Promise(fulfill => reader.onload = fulfill);
|
|
reader.readAsText(picker.files[0]);
|
|
return promise.then(() => reader.result);
|
|
})).toBe('contents of the file');
|
|
});
|
|
it('should be able to reset selected files with empty file list', async({page, server}) => {
|
|
await page.setContent(`<input type=file>`);
|
|
page.waitForFileChooser().then(chooser => chooser.accept([FILE_TO_UPLOAD]));
|
|
expect(await page.$eval('input', async picker => {
|
|
picker.click();
|
|
await new Promise(x => picker.oninput = x);
|
|
return picker.files.length;
|
|
})).toBe(1);
|
|
page.waitForFileChooser().then(chooser => chooser.accept([]));
|
|
expect(await page.$eval('input', async picker => {
|
|
picker.click();
|
|
await new Promise(x => picker.oninput = x);
|
|
return picker.files.length;
|
|
})).toBe(0);
|
|
});
|
|
it('should not accept multiple files for single-file input', async({page, server}) => {
|
|
await page.setContent(`<input type=file>`);
|
|
const [chooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.click('input'),
|
|
]);
|
|
let error = null;
|
|
await chooser.accept([
|
|
path.relative(process.cwd(), __dirname + '/assets/file-to-upload.txt'),
|
|
path.relative(process.cwd(), __dirname + '/assets/pptr.png'),
|
|
]).catch(e => error = e);
|
|
expect(error).not.toBe(null);
|
|
});
|
|
it('should fail when accepting file chooser twice', async({page, server}) => {
|
|
await page.setContent(`<input type=file>`);
|
|
const [fileChooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.$eval('input', input => input.click()),
|
|
]);
|
|
await fileChooser.accept([]);
|
|
let error = null;
|
|
await fileChooser.accept([]).catch(e => error = e);
|
|
expect(error.message).toBe('Cannot accept FileChooser which is already handled!');
|
|
});
|
|
});
|
|
|
|
describe_fails_ffox('FileChooser.cancel', function() {
|
|
it('should cancel dialog', async({page, server}) => {
|
|
// Consider file chooser canceled if we can summon another one.
|
|
// There's no reliable way in WebPlatform to see that FileChooser was
|
|
// canceled.
|
|
await page.setContent(`<input type=file>`);
|
|
const [fileChooser1] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.$eval('input', input => input.click()),
|
|
]);
|
|
await fileChooser1.cancel();
|
|
// If this resolves, than we successfully canceled file chooser.
|
|
await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.$eval('input', input => input.click()),
|
|
]);
|
|
});
|
|
it('should fail when canceling file chooser twice', async({page, server}) => {
|
|
await page.setContent(`<input type=file>`);
|
|
const [fileChooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.$eval('input', input => input.click()),
|
|
]);
|
|
await fileChooser.cancel();
|
|
let error = null;
|
|
await fileChooser.cancel().catch(e => error = e);
|
|
expect(error.message).toBe('Cannot cancel FileChooser which is already handled!');
|
|
});
|
|
});
|
|
|
|
describe_fails_ffox('FileChooser.isMultiple', () => {
|
|
it('should work for single file pick', async({page, server}) => {
|
|
await page.setContent(`<input type=file>`);
|
|
const [chooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.click('input'),
|
|
]);
|
|
expect(chooser.isMultiple()).toBe(false);
|
|
});
|
|
it('should work for "multiple"', async({page, server}) => {
|
|
await page.setContent(`<input multiple type=file>`);
|
|
const [chooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.click('input'),
|
|
]);
|
|
expect(chooser.isMultiple()).toBe(true);
|
|
});
|
|
it('should work for "webkitdirectory"', async({page, server}) => {
|
|
await page.setContent(`<input multiple webkitdirectory type=file>`);
|
|
const [chooser] = await Promise.all([
|
|
page.waitForFileChooser(),
|
|
page.click('input'),
|
|
]);
|
|
expect(chooser.isMultiple()).toBe(true);
|
|
});
|
|
});
|
|
};
|