Fix email configuration issue (#3732)

This commit is contained in:
rouja 2024-03-18 15:13:00 +01:00 committed by GitHub
parent 568701881e
commit 1b742f66c6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
10 changed files with 27 additions and 10 deletions

View File

@ -55,6 +55,7 @@ def send_export_email(email, slug, csv_buffer, rows):
EMAIL_HOST_PASSWORD, EMAIL_HOST_PASSWORD,
EMAIL_PORT, EMAIL_PORT,
EMAIL_USE_TLS, EMAIL_USE_TLS,
EMAIL_USE_SSL,
EMAIL_FROM, EMAIL_FROM,
) = get_email_configuration() ) = get_email_configuration()
@ -64,6 +65,7 @@ def send_export_email(email, slug, csv_buffer, rows):
username=EMAIL_HOST_USER, username=EMAIL_HOST_USER,
password=EMAIL_HOST_PASSWORD, password=EMAIL_HOST_PASSWORD,
use_tls=EMAIL_USE_TLS == "1", use_tls=EMAIL_USE_TLS == "1",
use_ssl=EMAIL_USE_SSL == "1",
) )
msg = EmailMultiAlternatives( msg = EmailMultiAlternatives(

View File

@ -185,6 +185,7 @@ def send_email_notification(
EMAIL_HOST_PASSWORD, EMAIL_HOST_PASSWORD,
EMAIL_PORT, EMAIL_PORT,
EMAIL_USE_TLS, EMAIL_USE_TLS,
EMAIL_USE_SSL,
EMAIL_FROM, EMAIL_FROM,
) = get_email_configuration() ) = get_email_configuration()
@ -288,6 +289,7 @@ def send_email_notification(
username=EMAIL_HOST_USER, username=EMAIL_HOST_USER,
password=EMAIL_HOST_PASSWORD, password=EMAIL_HOST_PASSWORD,
use_tls=EMAIL_USE_TLS == "1", use_tls=EMAIL_USE_TLS == "1",
use_ssl=EMAIL_USE_SSL == "1",
) )
msg = EmailMultiAlternatives( msg = EmailMultiAlternatives(

View File

@ -26,6 +26,7 @@ def forgot_password(first_name, email, uidb64, token, current_site):
EMAIL_HOST_PASSWORD, EMAIL_HOST_PASSWORD,
EMAIL_PORT, EMAIL_PORT,
EMAIL_USE_TLS, EMAIL_USE_TLS,
EMAIL_USE_SSL,
EMAIL_FROM, EMAIL_FROM,
) = get_email_configuration() ) = get_email_configuration()
@ -49,6 +50,7 @@ def forgot_password(first_name, email, uidb64, token, current_site):
username=EMAIL_HOST_USER, username=EMAIL_HOST_USER,
password=EMAIL_HOST_PASSWORD, password=EMAIL_HOST_PASSWORD,
use_tls=EMAIL_USE_TLS == "1", use_tls=EMAIL_USE_TLS == "1",
use_ssl=EMAIL_USE_SSL == "1",
) )
msg = EmailMultiAlternatives( msg = EmailMultiAlternatives(

View File

@ -23,6 +23,7 @@ def magic_link(email, key, token, current_site):
EMAIL_HOST_PASSWORD, EMAIL_HOST_PASSWORD,
EMAIL_PORT, EMAIL_PORT,
EMAIL_USE_TLS, EMAIL_USE_TLS,
EMAIL_USE_SSL,
EMAIL_FROM, EMAIL_FROM,
) = get_email_configuration() ) = get_email_configuration()
@ -41,6 +42,7 @@ def magic_link(email, key, token, current_site):
username=EMAIL_HOST_USER, username=EMAIL_HOST_USER,
password=EMAIL_HOST_PASSWORD, password=EMAIL_HOST_PASSWORD,
use_tls=EMAIL_USE_TLS == "1", use_tls=EMAIL_USE_TLS == "1",
use_ssl=EMAIL_USE_SSL == "1",
) )
msg = EmailMultiAlternatives( msg = EmailMultiAlternatives(

View File

@ -52,6 +52,7 @@ def project_invitation(email, project_id, token, current_site, invitor):
EMAIL_HOST_PASSWORD, EMAIL_HOST_PASSWORD,
EMAIL_PORT, EMAIL_PORT,
EMAIL_USE_TLS, EMAIL_USE_TLS,
EMAIL_USE_SSL,
EMAIL_FROM, EMAIL_FROM,
) = get_email_configuration() ) = get_email_configuration()
@ -61,6 +62,7 @@ def project_invitation(email, project_id, token, current_site, invitor):
username=EMAIL_HOST_USER, username=EMAIL_HOST_USER,
password=EMAIL_HOST_PASSWORD, password=EMAIL_HOST_PASSWORD,
use_tls=EMAIL_USE_TLS == "1", use_tls=EMAIL_USE_TLS == "1",
use_ssl=EMAIL_USE_SSL == "1",
) )
msg = EmailMultiAlternatives( msg = EmailMultiAlternatives(

View File

@ -257,6 +257,7 @@ def send_webhook_deactivation_email(
EMAIL_HOST_PASSWORD, EMAIL_HOST_PASSWORD,
EMAIL_PORT, EMAIL_PORT,
EMAIL_USE_TLS, EMAIL_USE_TLS,
EMAIL_USE_SSL,
EMAIL_FROM, EMAIL_FROM,
) = get_email_configuration() ) = get_email_configuration()
@ -285,6 +286,7 @@ def send_webhook_deactivation_email(
username=EMAIL_HOST_USER, username=EMAIL_HOST_USER,
password=EMAIL_HOST_PASSWORD, password=EMAIL_HOST_PASSWORD,
use_tls=EMAIL_USE_TLS == "1", use_tls=EMAIL_USE_TLS == "1",
use_ssl=EMAIL_USE_SSL == "1",
) )
msg = EmailMultiAlternatives( msg = EmailMultiAlternatives(

View File

@ -37,6 +37,7 @@ def workspace_invitation(email, workspace_id, token, current_site, invitor):
EMAIL_HOST_PASSWORD, EMAIL_HOST_PASSWORD,
EMAIL_PORT, EMAIL_PORT,
EMAIL_USE_TLS, EMAIL_USE_TLS,
EMAIL_USE_SSL,
EMAIL_FROM, EMAIL_FROM,
) = get_email_configuration() ) = get_email_configuration()
@ -65,6 +66,7 @@ def workspace_invitation(email, workspace_id, token, current_site, invitor):
username=EMAIL_HOST_USER, username=EMAIL_HOST_USER,
password=EMAIL_HOST_PASSWORD, password=EMAIL_HOST_PASSWORD,
use_tls=EMAIL_USE_TLS == "1", use_tls=EMAIL_USE_TLS == "1",
use_ssl=EMAIL_USE_SSL == "1",
) )
msg = EmailMultiAlternatives( msg = EmailMultiAlternatives(

View File

@ -64,6 +64,10 @@ def get_email_configuration():
"key": "EMAIL_USE_TLS", "key": "EMAIL_USE_TLS",
"default": os.environ.get("EMAIL_USE_TLS", "1"), "default": os.environ.get("EMAIL_USE_TLS", "1"),
}, },
{
"key": "EMAIL_USE_SSL",
"default": os.environ.get("EMAIL_USE_SSL", "0"),
},
{ {
"key": "EMAIL_FROM", "key": "EMAIL_FROM",
"default": os.environ.get( "default": os.environ.get(

View File

@ -18,7 +18,7 @@ export interface EmailFormValues {
EMAIL_HOST_USER: string; EMAIL_HOST_USER: string;
EMAIL_HOST_PASSWORD: string; EMAIL_HOST_PASSWORD: string;
EMAIL_USE_TLS: string; EMAIL_USE_TLS: string;
// EMAIL_USE_SSL: string; EMAIL_USE_SSL: string;
EMAIL_FROM: string; EMAIL_FROM: string;
} }
@ -41,7 +41,7 @@ export const InstanceEmailForm: FC<IInstanceEmailForm> = (props) => {
EMAIL_HOST_USER: config["EMAIL_HOST_USER"], EMAIL_HOST_USER: config["EMAIL_HOST_USER"],
EMAIL_HOST_PASSWORD: config["EMAIL_HOST_PASSWORD"], EMAIL_HOST_PASSWORD: config["EMAIL_HOST_PASSWORD"],
EMAIL_USE_TLS: config["EMAIL_USE_TLS"], EMAIL_USE_TLS: config["EMAIL_USE_TLS"],
// EMAIL_USE_SSL: config["EMAIL_USE_SSL"], EMAIL_USE_SSL: config["EMAIL_USE_SSL"],
EMAIL_FROM: config["EMAIL_FROM"], EMAIL_FROM: config["EMAIL_FROM"],
}, },
}); });
@ -218,7 +218,7 @@ export const InstanceEmailForm: FC<IInstanceEmailForm> = (props) => {
</div> </div>
</div> </div>
{/* <div className="flex items-center gap-10 pt-4 mr-8"> <div className="flex items-center gap-10 pt-4 mr-8">
<div className="grow"> <div className="grow">
<div className="text-custom-text-100 font-medium text-sm"> <div className="text-custom-text-100 font-medium text-sm">
Turn SSL {Boolean(parseInt(watch("EMAIL_USE_SSL"))) ? "off" : "on"} Turn SSL {Boolean(parseInt(watch("EMAIL_USE_SSL"))) ? "off" : "on"}
@ -242,7 +242,7 @@ export const InstanceEmailForm: FC<IInstanceEmailForm> = (props) => {
)} )}
/> />
</div> </div>
</div> */} </div>
</div> </div>
<div className="flex max-w-4xl items-center py-1"> <div className="flex max-w-4xl items-center py-1">

View File

@ -91,12 +91,11 @@ const InstanceAdminAuthorizationPage: NextPageWithLayout = observer(() => {
<div className={`shrink-0 ${isSubmitting && "opacity-70"}`}> <div className={`shrink-0 ${isSubmitting && "opacity-70"}`}>
<ToggleSwitch <ToggleSwitch
value={Boolean(parseInt(enableMagicLogin))} value={Boolean(parseInt(enableMagicLogin))}
// onChange={() => { onChange={() => {
// Boolean(parseInt(enableMagicLogin)) === true Boolean(parseInt(enableMagicLogin)) === true
// ? updateConfig("ENABLE_MAGIC_LINK_LOGIN", "0") ? updateConfig("ENABLE_MAGIC_LINK_LOGIN", "0")
// : updateConfig("ENABLE_MAGIC_LINK_LOGIN", "1"); : updateConfig("ENABLE_MAGIC_LINK_LOGIN", "1");
// }} }}
onChange={() => {}}
size="sm" size="sm"
disabled={isSubmitting} disabled={isSubmitting}
/> />