thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

fix: add existing issue modal fix (#3649)

Browse Source
This commit is contained in:
Anmol Singh Bhatia 2024-02-13 18:57:56 +05:30 committed by GitHub
parent eea3b4fa54
commit 1bf06821bb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/types/src/projects.d.ts vendored
View File

@ -1,5 +1,11 @@
import { EUserProjectRoles } from "constants/project"; import { EUserProjectRoles } from "constants/project";
import type { IUser, IUserLite, IWorkspace, IWorkspaceLite, TStateGroups } from "."; import type {
IUser,
IUserLite,
IWorkspace,
IWorkspaceLite,
TStateGroups,
} from ".";
export interface IProject { export interface IProject {
archive_in: number; archive_in: number;
@ -117,7 +123,7 @@ export type TProjectIssuesSearchParams = {
parent?: boolean; parent?: boolean;
issue_relation?: boolean; issue_relation?: boolean;
cycle?: boolean; cycle?: boolean;
module?: string[]; module?: string;
sub_issue?: boolean; sub_issue?: boolean;
issue_id?: string; issue_id?: string;
workspace_search: boolean; workspace_search: boolean;

12
web/components/core/modals/existing-issues-list-modal.tsx
View File

@ -78,7 +78,6 @@ export const ExistingIssuesListModal: React.FC<Props> = (props) => {
useEffect(() => { useEffect(() => {
if (!isOpen || !workspaceSlug || !projectId) return; if (!isOpen || !workspaceSlug || !projectId) return;
if (issues.length <= 0) setIsSearching(true);
projectService projectService
.projectIssuesSearch(workspaceSlug as string, projectId as string, { .projectIssuesSearch(workspaceSlug as string, projectId as string, {
@ -88,16 +87,7 @@ export const ExistingIssuesListModal: React.FC<Props> = (props) => {
}) })
.then((res) => setIssues(res)) .then((res) => setIssues(res))
.finally(() => setIsSearching(false)); .finally(() => setIsSearching(false));
}, [issues, debouncedSearchTerm, isOpen, isWorkspaceLevel, projectId, searchParams, workspaceSlug]); }, [debouncedSearchTerm, isOpen, isWorkspaceLevel, projectId, searchParams, workspaceSlug]);
useEffect(() => {
setSearchTerm("");
setIssues([]);
setSelectedIssues([]);
setIsSearching(false);
setIsSubmitting(false);
setIsWorkspaceLevel(false);
}, [isOpen]);
return ( return (
<> <>

2
web/components/issues/issue-layouts/empty-states/module.tsx
View File

@ -70,7 +70,7 @@ export const ModuleEmptyState: React.FC<Props> = observer((props) => {
projectId={projectId} projectId={projectId}
isOpen={moduleIssuesListModal} isOpen={moduleIssuesListModal}
handleClose={() => setModuleIssuesListModal(false)} handleClose={() => setModuleIssuesListModal(false)}
searchParams={{ module: moduleId != undefined ? [moduleId.toString()] : [] }} searchParams={{ module: moduleId != undefined ? moduleId.toString() : "" }}
handleOnSubmit={handleAddIssuesToModule} handleOnSubmit={handleAddIssuesToModule}
/> />
<div className="grid h-full w-full place-items-center"> <div className="grid h-full w-full place-items-center">

2
web/components/issues/issue-layouts/kanban/headers/group-by-card.tsx
View File

@ -59,7 +59,7 @@ export const HeaderGroupByCard: FC<IHeaderGroupByCard> = observer((props) => {
const { setToastAlert } = useToast(); const { setToastAlert } = useToast();
const renderExistingIssueModal = moduleId || cycleId; const renderExistingIssueModal = moduleId || cycleId;
const ExistingIssuesListModalPayload = moduleId ? { module: [moduleId.toString()] } : { cycle: true }; const ExistingIssuesListModalPayload = moduleId ? { module: moduleId.toString() } : { cycle: true };
const handleAddIssuesToView = async (data: ISearchIssueResponse[]) => { const handleAddIssuesToView = async (data: ISearchIssueResponse[]) => {
if (!workspaceSlug || !projectId) return; if (!workspaceSlug || !projectId) return;

2
web/components/issues/issue-layouts/list/headers/group-by-card.tsx
View File

@ -41,7 +41,7 @@ export const HeaderGroupByCard = observer(
const { setToastAlert } = useToast(); const { setToastAlert } = useToast();
const renderExistingIssueModal = moduleId || cycleId; const renderExistingIssueModal = moduleId || cycleId;
const ExistingIssuesListModalPayload = moduleId ? { module: [moduleId.toString()] } : { cycle: true }; const ExistingIssuesListModalPayload = moduleId ? { module: moduleId.toString() } : { cycle: true };
const handleAddIssuesToView = async (data: ISearchIssueResponse[]) => { const handleAddIssuesToView = async (data: ISearchIssueResponse[]) => {
if (!workspaceSlug || !projectId) return; if (!workspaceSlug || !projectId) return;