Merge pull request #3117 from makeplane/chore/issue_related_bug_and_improvement

chore: issue details related bug fixes and improvement
This commit is contained in:
sriram veeraghanta 2023-12-13 23:01:19 +05:30 committed by GitHub
commit 239f68e260
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 28 additions and 17 deletions

View File

@ -225,7 +225,7 @@ export const InboxMainContent: React.FC = observer(() => {
</> </>
) : null} ) : null}
</div> </div>
<div className="mb-5 flex items-center"> <div className="mb-2.5 flex items-center">
{currentIssueState && ( {currentIssueState && (
<StateGroupIcon <StateGroupIcon
className="mr-3 h-4 w-4" className="mr-3 h-4 w-4"

View File

@ -135,7 +135,7 @@ export const IssueDescriptionForm: FC<IssueDetailsProps> = (props) => {
debouncedFormSave(); debouncedFormSave();
}} }}
required required
className="min-h-10 block w-full resize-none overflow-hidden rounded border-none bg-transparent px-3 py-2 text-xl outline-none ring-0 focus:ring-1 focus:ring-custom-primary" className="min-h-min block w-full resize-none overflow-hidden rounded border-none bg-transparent px-3 py-2 text-2xl font-medium outline-none ring-0 focus:ring-1 focus:ring-custom-primary"
hasError={Boolean(errors?.description)} hasError={Boolean(errors?.description)}
role="textbox" role="textbox"
disabled={!isAllowed} disabled={!isAllowed}

View File

@ -100,7 +100,7 @@ export const IssuePropertyAssignee: React.FC<IIssuePropertyAssignee> = observer(
const label = ( const label = (
<Tooltip tooltipHeading="Assignee" tooltipContent={getTooltipContent()} position="top"> <Tooltip tooltipHeading="Assignee" tooltipContent={getTooltipContent()} position="top">
<div className="flex h-full w-full cursor-pointer items-center gap-2 text-custom-text-200"> <div className="flex h-full w-full items-center gap-2 text-custom-text-200">
{value && value.length > 0 && Array.isArray(value) ? ( {value && value.length > 0 && Array.isArray(value) ? (
<AvatarGroup showTooltip={false}> <AvatarGroup showTooltip={false}>
{value.map((assigneeId) => { {value.map((assigneeId) => {

View File

@ -216,7 +216,7 @@ export const IssueMainContent: React.FC<Props> = observer((props) => {
</CustomMenu> </CustomMenu>
</div> </div>
) : null} ) : null}
<div className="mb-5 flex items-center"> <div className="mb-2.5 flex items-center">
{currentIssueState && ( {currentIssueState && (
<StateGroupIcon <StateGroupIcon
className="mr-3 h-4 w-4" className="mr-3 h-4 w-4"

View File

@ -4,6 +4,8 @@ import { useRouter } from "next/router";
// components // components
import { ParentIssuesListModal } from "components/issues"; import { ParentIssuesListModal } from "components/issues";
// icons
import { X } from "lucide-react";
// types // types
import { IIssue, ISearchIssueResponse } from "types"; import { IIssue, ISearchIssueResponse } from "types";
@ -32,12 +34,20 @@ export const SidebarParentSelect: React.FC<Props> = ({ onChange, issueDetails, d
issueId={issueId as string} issueId={issueId as string}
projectId={projectId as string} projectId={projectId as string}
/> />
<button <button
type="button" type="button"
className={`rounded bg-custom-background-80 px-2.5 py-0.5 text-xs ${ className={`flex items-center gap-2 rounded bg-custom-background-80 px-2.5 py-0.5 text-xs max-w-max" ${
disabled ? "cursor-not-allowed" : "cursor-pointer " disabled ? "cursor-not-allowed" : "cursor-pointer "
}`} }`}
onClick={() => setIsParentModalOpen(true)} onClick={() => {
if (issueDetails?.parent) {
onChange("");
setSelectedParentIssue(null);
} else {
setIsParentModalOpen(true);
}
}}
disabled={disabled} disabled={disabled}
> >
{selectedParentIssue && issueDetails?.parent ? ( {selectedParentIssue && issueDetails?.parent ? (
@ -47,6 +57,7 @@ export const SidebarParentSelect: React.FC<Props> = ({ onChange, issueDetails, d
) : ( ) : (
<span className="text-custom-text-200">Select issue</span> <span className="text-custom-text-200">Select issue</span>
)} )}
{issueDetails?.parent && <X className="h-2.5 w-2.5" />}
</button> </button>
</> </>
); );

View File

@ -78,7 +78,7 @@ export const IssueProperty: React.FC<IIssueProperty> = (props) => {
projectId={issue?.project_detail?.id || null} projectId={issue?.project_detail?.id || null}
value={issue?.state || null} value={issue?.state || null}
onChange={(data) => handleStateChange(data)} onChange={(data) => handleStateChange(data)}
disabled={false} disabled={!editable}
hideDropdownArrow hideDropdownArrow
/> />
</div> </div>
@ -89,7 +89,7 @@ export const IssueProperty: React.FC<IIssueProperty> = (props) => {
value={issue?.assignees || null} value={issue?.assignees || null}
hideDropdownArrow hideDropdownArrow
onChange={(val) => handleAssigneeChange(val)} onChange={(val) => handleAssigneeChange(val)}
disabled={false} disabled={!editable}
/> />
</div> </div>
</div> </div>