From 35bb71303ed3736a9207c9a121dfabf4d2194d18 Mon Sep 17 00:00:00 2001
From: Dakshesh Jain <65905942+dakshesh14@users.noreply.github.com>
Date: Sun, 30 Jul 2023 02:05:30 +0530
Subject: [PATCH] refactor: fetching notification only when popover is open
 (#1706)

---
 .../notifications/notification-popover.tsx    | 247 +++++++++---------
 apps/app/hooks/use-user-notifications.tsx     |   4 +-
 2 files changed, 129 insertions(+), 122 deletions(-)

diff --git a/apps/app/components/notifications/notification-popover.tsx b/apps/app/components/notifications/notification-popover.tsx
index 6e495d875..0e57c472c 100644
--- a/apps/app/components/notifications/notification-popover.tsx
+++ b/apps/app/components/notifications/notification-popover.tsx
@@ -45,6 +45,7 @@ export const NotificationPopover = () => {
     isLoadingMore,
     hasMore,
     isRefreshing,
+    setFetchNotifications,
   } = useUserNotification();
 
   // theme context
@@ -66,130 +67,134 @@ export const NotificationPopover = () => {
         }}
       />
       <Popover className="relative w-full">
-        {({ open: isActive, close: closePopover }) => (
-          <>
-            <Tooltip
-              tooltipContent="Notifications"
-              position="right"
-              className="ml-2"
-              disabled={!sidebarCollapse}
-            >
-              <Popover.Button
-                className={`group flex w-full items-center gap-2.5 rounded-md px-3 py-2 text-sm font-medium outline-none ${
-                  isActive
-                    ? "bg-custom-primary-100/10 text-custom-primary-100"
-                    : "text-custom-sidebar-text-200 hover:bg-custom-sidebar-background-80"
-                } ${sidebarCollapse ? "justify-center" : ""}`}
-              >
-                <NotificationsOutlined fontSize="small" />
-                {sidebarCollapse ? null : <span>Notifications</span>}
-                {totalNotificationCount && totalNotificationCount > 0 ? (
-                  <span className="ml-auto bg-custom-primary-300 rounded-full text-xs text-white px-1.5">
-                    {getNumberCount(totalNotificationCount)}
-                  </span>
-                ) : null}
-              </Popover.Button>
-            </Tooltip>
-            <Transition
-              as={Fragment}
-              enter="transition ease-out duration-200"
-              enterFrom="opacity-0 translate-y-1"
-              enterTo="opacity-100 translate-y-0"
-              leave="transition ease-in duration-150"
-              leaveFrom="opacity-100 translate-y-0"
-              leaveTo="opacity-0 translate-y-1"
-            >
-              <Popover.Panel className="absolute bg-custom-background-100 flex flex-col left-0 md:left-full ml-8 z-10 top-0 md:w-[36rem] w-[20rem] h-[50vh] border border-custom-border-300 shadow-lg rounded-xl">
-                <NotificationHeader
-                  notificationCount={notificationCount}
-                  notificationMutate={notificationMutate}
-                  closePopover={closePopover}
-                  isRefreshing={isRefreshing}
-                  snoozed={snoozed}
-                  archived={archived}
-                  readNotification={readNotification}
-                  selectedTab={selectedTab}
-                  setSnoozed={setSnoozed}
-                  setArchived={setArchived}
-                  setReadNotification={setReadNotification}
-                  setSelectedTab={setSelectedTab}
-                />
+        {({ open: isActive, close: closePopover }) => {
+          if (isActive) setFetchNotifications(true);
 
-                {notifications ? (
-                  notifications.length > 0 ? (
-                    <div className="h-full overflow-y-auto">
-                      <div className="divide-y divide-custom-border-100">
-                        {notifications.map((notification) => (
-                          <NotificationCard
-                            key={notification.id}
-                            notification={notification}
-                            markNotificationArchivedStatus={markNotificationArchivedStatus}
-                            markNotificationReadStatus={markNotificationReadStatus}
-                            setSelectedNotificationForSnooze={setSelectedNotificationForSnooze}
-                            markSnoozeNotification={markSnoozeNotification}
-                          />
-                        ))}
-                      </div>
-                      {isLoadingMore && (
-                        <div className="my-6 flex justify-center items-center text-sm">
-                          <div role="status">
-                            <svg
-                              aria-hidden="true"
-                              className="mr-2 h-6 w-6 animate-spin fill-blue-600 text-custom-text-200"
-                              viewBox="0 0 100 101"
-                              fill="none"
-                              xmlns="http://www.w3.org/2000/svg"
-                            >
-                              <path
-                                d="M100 50.5908C100 78.2051 77.6142 100.591 50 100.591C22.3858 100.591 0 78.2051 0 50.5908C0 22.9766 22.3858 0.59082 50 0.59082C77.6142 0.59082 100 22.9766 100 50.5908ZM9.08144 50.5908C9.08144 73.1895 27.4013 91.5094 50 91.5094C72.5987 91.5094 90.9186 73.1895 90.9186 50.5908C90.9186 27.9921 72.5987 9.67226 50 9.67226C27.4013 9.67226 9.08144 27.9921 9.08144 50.5908Z"
-                                fill="currentColor"
-                              />
-                              <path
-                                d="M93.9676 39.0409C96.393 38.4038 97.8624 35.9116 97.0079 33.5539C95.2932 28.8227 92.871 24.3692 89.8167 20.348C85.8452 15.1192 80.8826 10.7238 75.2124 7.41289C69.5422 4.10194 63.2754 1.94025 56.7698 1.05124C51.7666 0.367541 46.6976 0.446843 41.7345 1.27873C39.2613 1.69328 37.813 4.19778 38.4501 6.62326C39.0873 9.04874 41.5694 10.4717 44.0505 10.1071C47.8511 9.54855 51.7191 9.52689 55.5402 10.0491C60.8642 10.7766 65.9928 12.5457 70.6331 15.2552C75.2735 17.9648 79.3347 21.5619 82.5849 25.841C84.9175 28.9121 86.7997 32.2913 88.1811 35.8758C89.083 38.2158 91.5421 39.6781 93.9676 39.0409Z"
-                                fill="currentFill"
-                              />
-                            </svg>
-                            <span className="sr-only">Loading...</span>
-                          </div>
-                          <p>Loading notifications</p>
+          return (
+            <>
+              <Tooltip
+                tooltipContent="Notifications"
+                position="right"
+                className="ml-2"
+                disabled={!sidebarCollapse}
+              >
+                <Popover.Button
+                  className={`group flex w-full items-center gap-2.5 rounded-md px-3 py-2 text-sm font-medium outline-none ${
+                    isActive
+                      ? "bg-custom-primary-100/10 text-custom-primary-100"
+                      : "text-custom-sidebar-text-200 hover:bg-custom-sidebar-background-80"
+                  } ${sidebarCollapse ? "justify-center" : ""}`}
+                >
+                  <NotificationsOutlined fontSize="small" />
+                  {sidebarCollapse ? null : <span>Notifications</span>}
+                  {totalNotificationCount && totalNotificationCount > 0 ? (
+                    <span className="ml-auto bg-custom-primary-300 rounded-full text-xs text-white px-1.5">
+                      {getNumberCount(totalNotificationCount)}
+                    </span>
+                  ) : null}
+                </Popover.Button>
+              </Tooltip>
+              <Transition
+                as={Fragment}
+                enter="transition ease-out duration-200"
+                enterFrom="opacity-0 translate-y-1"
+                enterTo="opacity-100 translate-y-0"
+                leave="transition ease-in duration-150"
+                leaveFrom="opacity-100 translate-y-0"
+                leaveTo="opacity-0 translate-y-1"
+              >
+                <Popover.Panel className="absolute bg-custom-background-100 flex flex-col left-0 md:left-full ml-8 z-10 top-0 md:w-[36rem] w-[20rem] h-[50vh] border border-custom-border-300 shadow-lg rounded-xl">
+                  <NotificationHeader
+                    notificationCount={notificationCount}
+                    notificationMutate={notificationMutate}
+                    closePopover={closePopover}
+                    isRefreshing={isRefreshing}
+                    snoozed={snoozed}
+                    archived={archived}
+                    readNotification={readNotification}
+                    selectedTab={selectedTab}
+                    setSnoozed={setSnoozed}
+                    setArchived={setArchived}
+                    setReadNotification={setReadNotification}
+                    setSelectedTab={setSelectedTab}
+                  />
+
+                  {notifications ? (
+                    notifications.length > 0 ? (
+                      <div className="h-full overflow-y-auto">
+                        <div className="divide-y divide-custom-border-100">
+                          {notifications.map((notification) => (
+                            <NotificationCard
+                              key={notification.id}
+                              notification={notification}
+                              markNotificationArchivedStatus={markNotificationArchivedStatus}
+                              markNotificationReadStatus={markNotificationReadStatus}
+                              setSelectedNotificationForSnooze={setSelectedNotificationForSnooze}
+                              markSnoozeNotification={markSnoozeNotification}
+                            />
+                          ))}
                         </div>
-                      )}
-                      {hasMore && !isLoadingMore && (
-                        <button
-                          type="button"
-                          className="text-custom-primary-100 my-6 flex justify-center items-center w-full text-sm font-medium"
-                          disabled={isLoadingMore}
-                          onClick={() => {
-                            setSize((prev) => prev + 1);
-                          }}
-                        >
-                          Load More
-                        </button>
-                      )}
-                    </div>
+                        {isLoadingMore && (
+                          <div className="my-6 flex justify-center items-center text-sm">
+                            <div role="status">
+                              <svg
+                                aria-hidden="true"
+                                className="mr-2 h-6 w-6 animate-spin fill-blue-600 text-custom-text-200"
+                                viewBox="0 0 100 101"
+                                fill="none"
+                                xmlns="http://www.w3.org/2000/svg"
+                              >
+                                <path
+                                  d="M100 50.5908C100 78.2051 77.6142 100.591 50 100.591C22.3858 100.591 0 78.2051 0 50.5908C0 22.9766 22.3858 0.59082 50 0.59082C77.6142 0.59082 100 22.9766 100 50.5908ZM9.08144 50.5908C9.08144 73.1895 27.4013 91.5094 50 91.5094C72.5987 91.5094 90.9186 73.1895 90.9186 50.5908C90.9186 27.9921 72.5987 9.67226 50 9.67226C27.4013 9.67226 9.08144 27.9921 9.08144 50.5908Z"
+                                  fill="currentColor"
+                                />
+                                <path
+                                  d="M93.9676 39.0409C96.393 38.4038 97.8624 35.9116 97.0079 33.5539C95.2932 28.8227 92.871 24.3692 89.8167 20.348C85.8452 15.1192 80.8826 10.7238 75.2124 7.41289C69.5422 4.10194 63.2754 1.94025 56.7698 1.05124C51.7666 0.367541 46.6976 0.446843 41.7345 1.27873C39.2613 1.69328 37.813 4.19778 38.4501 6.62326C39.0873 9.04874 41.5694 10.4717 44.0505 10.1071C47.8511 9.54855 51.7191 9.52689 55.5402 10.0491C60.8642 10.7766 65.9928 12.5457 70.6331 15.2552C75.2735 17.9648 79.3347 21.5619 82.5849 25.841C84.9175 28.9121 86.7997 32.2913 88.1811 35.8758C89.083 38.2158 91.5421 39.6781 93.9676 39.0409Z"
+                                  fill="currentFill"
+                                />
+                              </svg>
+                              <span className="sr-only">Loading...</span>
+                            </div>
+                            <p>Loading notifications</p>
+                          </div>
+                        )}
+                        {hasMore && !isLoadingMore && (
+                          <button
+                            type="button"
+                            className="text-custom-primary-100 my-6 flex justify-center items-center w-full text-sm font-medium"
+                            disabled={isLoadingMore}
+                            onClick={() => {
+                              setSize((prev) => prev + 1);
+                            }}
+                          >
+                            Load More
+                          </button>
+                        )}
+                      </div>
+                    ) : (
+                      <div className="grid h-full w-full place-items-center overflow-hidden scale-75">
+                        <EmptyState
+                          title="You're updated with all the notifications"
+                          description="You have read all the notifications."
+                          image={emptyNotification}
+                          isFullScreen={false}
+                        />
+                      </div>
+                    )
                   ) : (
-                    <div className="grid h-full w-full place-items-center overflow-hidden scale-75">
-                      <EmptyState
-                        title="You're updated with all the notifications"
-                        description="You have read all the notifications."
-                        image={emptyNotification}
-                        isFullScreen={false}
-                      />
-                    </div>
-                  )
-                ) : (
-                  <Loader className="p-5 space-y-4 overflow-y-auto">
-                    <Loader.Item height="50px" />
-                    <Loader.Item height="50px" />
-                    <Loader.Item height="50px" />
-                    <Loader.Item height="50px" />
-                    <Loader.Item height="50px" />
-                  </Loader>
-                )}
-              </Popover.Panel>
-            </Transition>
-          </>
-        )}
+                    <Loader className="p-5 space-y-4 overflow-y-auto">
+                      <Loader.Item height="50px" />
+                      <Loader.Item height="50px" />
+                      <Loader.Item height="50px" />
+                      <Loader.Item height="50px" />
+                      <Loader.Item height="50px" />
+                    </Loader>
+                  )}
+                </Popover.Panel>
+              </Transition>
+            </>
+          );
+        }}
       </Popover>
     </>
   );
diff --git a/apps/app/hooks/use-user-notifications.tsx b/apps/app/hooks/use-user-notifications.tsx
index e7880dadf..53e155032 100644
--- a/apps/app/hooks/use-user-notifications.tsx
+++ b/apps/app/hooks/use-user-notifications.tsx
@@ -25,6 +25,7 @@ const useUserNotification = () => {
   const [snoozed, setSnoozed] = useState<boolean>(false);
   const [archived, setArchived] = useState<boolean>(false);
   const [readNotification, setReadNotification] = useState<boolean>(false);
+  const [fetchNotifications, setFetchNotifications] = useState<boolean>(false);
   const [selectedNotificationForSnooze, setSelectedNotificationForSnooze] = useState<string | null>(
     null
   );
@@ -49,7 +50,7 @@ const useUserNotification = () => {
     isValidating,
     mutate: notificationMutate,
   } = useSWRInfinite(
-    workspaceSlug
+    fetchNotifications && workspaceSlug
       ? (index, prevData) =>
           getPaginatedNotificationKey(index, prevData, workspaceSlug.toString(), params)
       : () => null,
@@ -282,6 +283,7 @@ const useUserNotification = () => {
     isLoadingMore,
     hasMore,
     isRefreshing,
+    setFetchNotifications,
   };
 };