thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

chore: remove placeholder from estimate property if no estimates are selected. (#4125)

Browse Source
This commit is contained in:
Prateek Shourya 2024-04-08 18:38:39 +05:30 committed by GitHub
parent 986f81e3ae
commit 39b5a58ce8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/components/dropdowns/estimate.tsx
View File

@ -48,7 +48,7 @@ export const EstimateDropdown: React.FC<Props> = observer((props) => {
hideIcon = false, hideIcon = false,
onChange, onChange,
onClose, onClose,
placeholder = "Estimate", placeholder = "",
placement, placement,
projectId, projectId,
showTooltip = false, showTooltip = false,
@ -197,7 +197,7 @@ export const EstimateDropdown: React.FC<Props> = observer((props) => {
variant={buttonVariant} variant={buttonVariant}
> >
{!hideIcon && <Triangle className="h-3 w-3 flex-shrink-0" />} {!hideIcon && <Triangle className="h-3 w-3 flex-shrink-0" />}
{BUTTON_VARIANTS_WITH_TEXT.includes(buttonVariant) && ( {(selectedEstimate || placeholder) && BUTTON_VARIANTS_WITH_TEXT.includes(buttonVariant) && (
<span className="flex-grow truncate">{selectedEstimate !== null ? selectedEstimate : placeholder}</span> <span className="flex-grow truncate">{selectedEstimate !== null ? selectedEstimate : placeholder}</span>
)} )}
{dropdownArrow && ( {dropdownArrow && (

1
web/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx
View File

@ -21,6 +21,7 @@ export const SpreadsheetEstimateColumn: React.FC<Props> = observer((props: Props
onChange={(data) => onChange={(data) =>
onChange(issue, { estimate_point: data }, { changed_property: "estimate_point", change_details: data }) onChange(issue, { estimate_point: data }, { changed_property: "estimate_point", change_details: data })
} }
placeholder="Estimate"
projectId={issue.project_id} projectId={issue.project_id}
disabled={disabled} disabled={disabled}
buttonVariant="transparent-with-text" buttonVariant="transparent-with-text"