thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

[WEB-762] chore: cycle, module modal improvement and cycle, module (#4000)

Browse Source 
* chore: cycle modal description improvement

* chore: updated the description ui in cycles and modules

---------

Co-authored-by: gurusainath <gurusainath007@gmail.com>
This commit is contained in:
Anmol Singh Bhatia 2024-03-20 20:41:49 +05:30 committed by GitHub
parent 37c5ce54d5
commit 3ff0f6187a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/components/cycles/form.tsx
View File

@ -113,7 +113,7 @@ export const CycleForm: React.FC<Props> = (props) => {
id="cycle_description" id="cycle_description"
name="description" name="description"
placeholder="Description..." placeholder="Description..."
className="!h-24 w-full resize-none text-sm" className="w-full text-sm resize-none min-h-24"
hasError={Boolean(errors?.description)} hasError={Boolean(errors?.description)}
value={value} value={value}
onChange={onChange} onChange={onChange}

14
web/components/cycles/sidebar.tsx
View File

@ -8,7 +8,7 @@ import { Disclosure, Transition } from "@headlessui/react";
// icons // icons
import { ICycle } from "@plane/types"; import { ICycle } from "@plane/types";
// ui // ui
import { Avatar, CustomMenu, Loader, LayersIcon, TOAST_TYPE, setToast } from "@plane/ui"; import { Avatar, CustomMenu, Loader, LayersIcon, TOAST_TYPE, setToast, TextArea } from "@plane/ui";
// components // components
import { SidebarProgressStats } from "@/components/core"; import { SidebarProgressStats } from "@/components/core";
import ProgressChart from "@/components/core/sidebar/progress-chart"; import ProgressChart from "@/components/core/sidebar/progress-chart";
@ -219,8 +219,8 @@ export const CycleDetailsSidebar: React.FC<Props> = observer((props) => {
? "0 Issue" ? "0 Issue"
: `${cycleDetails.progress_snapshot.completed_issues}/${cycleDetails.progress_snapshot.total_issues}` : `${cycleDetails.progress_snapshot.completed_issues}/${cycleDetails.progress_snapshot.total_issues}`
: cycleDetails.total_issues === 0 : cycleDetails.total_issues === 0
? "0 Issue" ? "0 Issue"
: `${cycleDetails.completed_issues}/${cycleDetails.total_issues}`; : `${cycleDetails.completed_issues}/${cycleDetails.total_issues}`;
const daysLeft = findHowManyDaysLeft(cycleDetails.end_date); const daysLeft = findHowManyDaysLeft(cycleDetails.end_date);
@ -290,9 +290,11 @@ export const CycleDetailsSidebar: React.FC<Props> = observer((props) => {
</div> </div>
{cycleDetails.description && ( {cycleDetails.description && (
<span className="w-full whitespace-normal break-words py-2.5 text-sm leading-5 text-custom-text-200"> <TextArea
{cycleDetails.description} className="outline-none ring-none w-full max-h-max bg-transparent !p-0 !m-0 !border-0 resize-none text-sm leading-5 text-custom-text-200"
</span> value={cycleDetails.description}
disabled
/>
)} )}
<div className="flex flex-col gap-5 pb-6 pt-2.5"> <div className="flex flex-col gap-5 pb-6 pt-2.5">

2
web/components/modules/form.tsx
View File

@ -128,7 +128,7 @@ export const ModuleForm: React.FC<Props> = (props) => {
value={value} value={value}
onChange={onChange} onChange={onChange}
placeholder="Description..." placeholder="Description..."
className="h-24 w-full resize-none text-sm" className="w-full text-sm resize-none min-h-24"
hasError={Boolean(errors?.description)} hasError={Boolean(errors?.description)}
tabIndex={2} tabIndex={2}
/> />

9
web/components/modules/sidebar.tsx
View File

@ -25,6 +25,7 @@ import {
UserGroupIcon, UserGroupIcon,
TOAST_TYPE, TOAST_TYPE,
setToast, setToast,
TextArea,
} from "@plane/ui"; } from "@plane/ui";
// components // components
import { LinkModal, LinksList, SidebarProgressStats } from "@/components/core"; import { LinkModal, LinksList, SidebarProgressStats } from "@/components/core";
@ -337,9 +338,11 @@ export const ModuleDetailsSidebar: React.FC<Props> = observer((props) => {
</div> </div>
{moduleDetails.description && ( {moduleDetails.description && (
<span className="w-full whitespace-normal break-words py-2.5 text-sm leading-5 text-custom-text-200"> <TextArea
{moduleDetails.description} className="outline-none ring-none w-full max-h-max bg-transparent !p-0 !m-0 !border-0 resize-none text-sm leading-5 text-custom-text-200"
</span> value={moduleDetails.description}
disabled
/>
)} )}
<div className="flex items-center justify-start gap-1"> <div className="flex items-center justify-start gap-1">