thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

Merge pull request #56 from pablohashescobar/refactor/module_cycle_issue

Browse Source 
refactor: make both cycle issue and module issue view consistent
This commit is contained in:
Vamsi Kurama 2022-12-21 23:29:30 +05:30 committed by GitHub
commit 443334774e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apiserver/plane/api/views/cycle.py
View File

@ -70,7 +70,7 @@ class CycleIssueViewSet(BaseViewSet):
def create(self, request, slug, project_id, cycle_id): def create(self, request, slug, project_id, cycle_id):
try: try:
issues = request.data.get("issue", []) issues = request.data.get("issues", [])
if not len(issues): if not len(issues):
return Response( return Response(

8
apiserver/plane/api/views/module.py
View File

@ -15,7 +15,7 @@ from plane.api.serializers import (
ModuleIssueSerializer, ModuleIssueSerializer,
) )
from plane.api.permissions import ProjectEntityPermission from plane.api.permissions import ProjectEntityPermission
from plane.db.models import Module, ModuleIssue, Project from plane.db.models import Module, ModuleIssue, Project, Issue
class ModuleViewSet(BaseViewSet): class ModuleViewSet(BaseViewSet):
@ -80,7 +80,6 @@ class ModuleViewSet(BaseViewSet):
) )
class ModuleIssueViewSet(BaseViewSet): class ModuleIssueViewSet(BaseViewSet):
serializer_class = ModuleIssueSerializer serializer_class = ModuleIssueSerializer
@ -126,6 +125,11 @@ class ModuleIssueViewSet(BaseViewSet):
module = Module.objects.get( module = Module.objects.get(
workspace__slug=slug, project_id=project_id, pk=module_id workspace__slug=slug, project_id=project_id, pk=module_id
) )
issues = Issue.objects.filter(
pk__in=issues, workspace__slug=slug, project_id=project_id
)
ModuleIssue.objects.bulk_create( ModuleIssue.objects.bulk_create(
[ [
ModuleIssue( ModuleIssue(