thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

chore: asset key validation in user assets

Browse Source
This commit is contained in:
Bavisetti Narayan 2023-08-22 18:31:35 +05:30
parent 660e181627
commit 53c7388d3b
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
apiserver/plane/api/views/asset.py
View File

@ -21,7 +21,6 @@ class FileAssetEndpoint(BaseAPIView):
try: try:
asset_key = str(workspace_id) + "/" + asset_key asset_key = str(workspace_id) + "/" + asset_key
files = FileAsset.objects.filter(asset=asset_key) files = FileAsset.objects.filter(asset=asset_key)
serializer = FileAssetSerializer(files, context={"request": request}, many=True)
if files.exists(): if files.exists():
serializer = FileAssetSerializer(files, context={"request": request}, many=True) serializer = FileAssetSerializer(files, context={"request": request}, many=True)
return Response({"data": serializer.data, "status": True}, status=status.HTTP_200_OK) return Response({"data": serializer.data, "status": True}, status=status.HTTP_200_OK)
@ -80,11 +79,16 @@ class UserAssetsEndpoint(BaseAPIView):
def get(self, request, asset_key): def get(self, request, asset_key):
try: try:
files = FileAsset.objects.filter(asset=asset_key, created_by=request.user) files = FileAsset.objects.filter(asset=asset_key, created_by=request.user)
serializer = FileAssetSerializer(files, context={"request": request}) if files.exists():
return Response(serializer.data) serializer = FileAssetSerializer(files, context={"request": request})
except FileAsset.DoesNotExist: return Response({"data": serializer.data, "status": True}, status=status.HTTP_200_OK)
else:
return Response({"error": "Asset key does not exist", "status": False}, status=status.HTTP_200_OK)
except Exception as e:
capture_exception(e)
return Response( return Response(
{"error": "File Asset does not exist"}, status=status.HTTP_404_NOT_FOUND {"error": "Something went wrong please try again later"},
status=status.HTTP_400_BAD_REQUEST,
) )
def post(self, request): def post(self, request):