thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

fix: handled inital empty state close in the issue create/edit odal (#4033)

Browse Source
This commit is contained in:
guru_sainath 2024-03-22 18:28:44 +05:30 committed by GitHub
parent baab6ce99f
commit 60aea62739
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
web/components/issues/issue-modal/draft-issue-layout.tsx
View File

@ -53,7 +53,7 @@ export const DraftIssueLayout: React.FC<DraftIssueProps> = observer((props) => {
Object.entries(changesMade).forEach(([key, value]) => { Object.entries(changesMade).forEach(([key, value]) => {
const issueKey = key as keyof TIssue; const issueKey = key as keyof TIssue;
if (value === null || value === undefined || value === "") delete changesMade[issueKey]; if (value === null || value === undefined || value === "") delete changesMade[issueKey];
if (typeof value === "object" && !value) delete changesMade[issueKey]; if (typeof value === "object" && isEmpty(value)) delete changesMade[issueKey];
if (Array.isArray(value) && value.length === 0) delete changesMade[issueKey]; if (Array.isArray(value) && value.length === 0) delete changesMade[issueKey];
if (issueKey === "project_id") delete changesMade.project_id; if (issueKey === "project_id") delete changesMade.project_id;
if (issueKey === "priority" && value && value === "none") delete changesMade.priority; if (issueKey === "priority" && value && value === "none") delete changesMade.priority;
@ -64,8 +64,13 @@ export const DraftIssueLayout: React.FC<DraftIssueProps> = observer((props) => {
) )
delete changesMade.description_html; delete changesMade.description_html;
}); });
if (isEmpty(changesMade)) onClose(false); if (isEmpty(changesMade)) {
else setIssueDiscardModal(true); onClose(false);
setIssueDiscardModal(false);
} else setIssueDiscardModal(true);
} else {
onClose(false);
setIssueDiscardModal(false);
} }
}; };