From 71b73000d233a0712f0c87706fe7394ca988d946 Mon Sep 17 00:00:00 2001 From: Crsi <47722349+CrsiX@users.noreply.github.com> Date: Thu, 4 Apr 2024 09:07:50 +0000 Subject: [PATCH] Dropped version info from docker-compose files (#4096) According to the docker issue 11628 (https://github.com/docker/compose/issues/11628) the 'version' field in docker-compose files is outdated. It shows a warning like the following on hosts with a newer Docker version: ``` WARN[0000] /srv/plane/docker-compose.yaml: `version` is obsolete ``` Also, the specs itself state the version was only informative: https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-and-name-top-level-elements > The top-level `version` property is defined by the Compose > Specification for backward compatibility. It is only informative. > Compose doesn't use version to select an exact schema to > validate the Compose file, but prefers the most recent schema > when it's implemented. --- deploy/selfhost/docker-compose.yml | 2 -- docker-compose-local.yml | 2 -- docker-compose.yml | 2 -- 3 files changed, 6 deletions(-) diff --git a/deploy/selfhost/docker-compose.yml b/deploy/selfhost/docker-compose.yml index 522baf63d..e62390987 100644 --- a/deploy/selfhost/docker-compose.yml +++ b/deploy/selfhost/docker-compose.yml @@ -1,5 +1,3 @@ -version: "3.8" - x-app-env: &app-env environment: - NGINX_PORT=${NGINX_PORT:-80} diff --git a/docker-compose-local.yml b/docker-compose-local.yml index 5f49e4897..a68a045dd 100644 --- a/docker-compose-local.yml +++ b/docker-compose-local.yml @@ -1,5 +1,3 @@ -version: "3.8" - networks: dev_env: driver: bridge diff --git a/docker-compose.yml b/docker-compose.yml index e39f0d8d2..6efe0e0a1 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -1,5 +1,3 @@ -version: "3.8" - services: web: container_name: web