thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

fix: spreadsheet layout issue properties (#2936)

Browse Source 
* fix: spredsheet layout state column state name & tootltip

* fix: label select dropdown first item auto active state

* fix: priority column padding & tooltip position
This commit is contained in:
Lakhan Baheti 2023-11-29 14:20:58 +05:30 committed by GitHub
parent 6d175c0e56
commit 7cd02401c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/components/issues/issue-layouts/properties/labels.tsx
View File

@ -201,10 +201,9 @@ export const IssuePropertyLabels: React.FC<IIssuePropertyLabels> = observer((pro
<Combobox.Option <Combobox.Option
key={option.value} key={option.value}
value={option.value} value={option.value}
className={({ active, selected }) => className={({ selected }) =>
`flex items-center justify-between gap-2 cursor-pointer select-none truncate rounded px-1 py-1.5 ${ `flex items-center justify-between gap-2 cursor-pointer select-none truncate rounded px-1 py-1.5 hover:bg-custom-background-80
active ? "bg-custom-background-80" : "" ${selected ? "text-custom-text-100" : "text-custom-text-200"}`
} ${selected ? "text-custom-text-100" : "text-custom-text-200"}`
} }
> >
{({ selected }) => ( {({ selected }) => (

2
web/components/issues/issue-layouts/properties/priority.tsx
View File

@ -17,7 +17,7 @@ export const IssuePropertyPriority: React.FC<IIssuePropertyPriority> = observer(
<PrioritySelect <PrioritySelect
value={value} value={value}
onChange={onChange} onChange={onChange}
buttonClassName="!h-5 p-1.5" buttonClassName="!h-5"
disabled={disabled} disabled={disabled}
hideDropdownArrow={hideDropdownArrow} hideDropdownArrow={hideDropdownArrow}
/> />

2
web/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx
View File

@ -26,7 +26,7 @@ export const SpreadsheetStateColumn: React.FC<Props> = (props) => {
<> <>
<IssuePropertyState <IssuePropertyState
projectId={issue.project_detail?.id ?? null} projectId={issue.project_detail?.id ?? null}
value={issue.state_detail} value={issue.state_detail.id}
onChange={(data) => onChange({ state: data.id, state_detail: data })} onChange={(data) => onChange({ state: data.id, state_detail: data })}
className="h-full w-full" className="h-full w-full"
buttonClassName="!shadow-none !border-0 h-full w-full" buttonClassName="!shadow-none !border-0 h-full w-full"

4
web/components/project/priority-select.tsx
View File

@ -71,7 +71,7 @@ export const PrioritySelect: React.FC<Props> = ({
const label = ( const label = (
<Tooltip tooltipHeading="Priority" tooltipContent={selectedOption} position="top"> <Tooltip tooltipHeading="Priority" tooltipContent={selectedOption} position="top">
<div className="flex items-center gap-2"> <div className="flex items-center w-full gap-2">
<PriorityIcon <PriorityIcon
priority={value} priority={value}
className={`h-3.5 w-3.5`} className={`h-3.5 w-3.5`}
@ -93,7 +93,7 @@ export const PrioritySelect: React.FC<Props> = ({
<button <button
ref={setReferenceElement} ref={setReferenceElement}
type="button" type="button"
className={`flex items-center justify-between gap-1 h-full w-full !p-0 ${disabled ? "cursor-not-allowed text-custom-text-200" : "cursor-pointer"} ${buttonClassName}`} className={`flex items-center justify-between gap-1 h-full w-full ${disabled ? "cursor-not-allowed text-custom-text-200" : "cursor-pointer"} ${buttonClassName}`}
> >
{label} {label}
{!hideDropdownArrow && !disabled && <ChevronDown className="h-2.5 w-2.5" aria-hidden="true" />} {!hideDropdownArrow && !disabled && <ChevronDown className="h-2.5 w-2.5" aria-hidden="true" />}