thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

fix: spreadsheet views sorting (#3683)

Browse Source 
* fix sorting in spreadsheet all issues

* removing focus border since it is being handled globally
This commit is contained in:
rahulramesha 2024-02-16 18:20:44 +05:30 committed by GitHub
parent 7628419a26
commit 85a8af5125
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/components/issues/issue-layouts/roots/all-issue-layout-root.tsx
View File

@ -159,7 +159,7 @@ export const AllIssueLayoutRoot: React.FC = observer(() => {
globalViewId.toString() globalViewId.toString()
); );
}, },
[updateFilters, workspaceSlug] [updateFilters, workspaceSlug, globalViewId]
); );
const renderQuickActions = useCallback( const renderQuickActions = useCallback(

2
web/components/issues/issue-layouts/spreadsheet/base-spreadsheet-root.tsx
View File

@ -88,7 +88,7 @@ export const BaseSpreadsheetRoot = observer((props: IBaseSpreadsheetRoot) => {
viewId viewId
); );
}, },
[issueFiltersStore, projectId, workspaceSlug, viewId] [issueFiltersStore?.updateFilters, projectId, workspaceSlug, viewId]
); );
const renderQuickActions = useCallback( const renderQuickActions = useCallback(

2
web/components/issues/issue-layouts/spreadsheet/issue-column.tsx
View File

@ -38,7 +38,7 @@ export const IssueColumn = observer((props: Props) => {
> >
<td <td
tabIndex={0} tabIndex={0}
className="h-11 w-full min-w-[8rem] bg-custom-background-100 text-sm after:absolute after:w-full after:bottom-[-1px] after:border after:border-custom-border-100 border-r-[1px] border-custom-border-100 focus:border-custom-primary-70" className="h-11 w-full min-w-[8rem] bg-custom-background-100 text-sm after:absolute after:w-full after:bottom-[-1px] after:border after:border-custom-border-100 border-r-[1px] border-custom-border-100"
ref={tableCellRef} ref={tableCellRef}
> >
<Column <Column

2
web/components/issues/issue-layouts/spreadsheet/spreadsheet-header-column.tsx
View File

@ -28,7 +28,7 @@ export const SpreadsheetHeaderColumn = observer((props: Props) => {
shouldRenderProperty={shouldRenderProperty} shouldRenderProperty={shouldRenderProperty}
> >
<th <th
className="h-11 w-full min-w-[8rem] items-center bg-custom-background-90 text-sm font-medium px-4 py-1 border border-b-0 border-t-0 border-custom-border-100 focus:border-custom-primary-70" className="h-11 w-full min-w-[8rem] items-center bg-custom-background-90 text-sm font-medium px-4 py-1 border border-b-0 border-t-0 border-custom-border-100"
ref={tableHeaderCellRef} ref={tableHeaderCellRef}
tabIndex={0} tabIndex={0}
> >

2
web/store/issue/helpers/issue-helper.store.ts
View File

@ -202,7 +202,7 @@ export class IssueHelperStore implements TIssueHelperStore {
if (!memberMap) break; if (!memberMap) break;
for (const dataId of dataIdsArray) { for (const dataId of dataIdsArray) {
const member = memberMap[dataId]; const member = memberMap[dataId];
if (memberMap && member.first_name) dataValues.push(member.first_name.toLocaleLowerCase()); if (member && member.first_name) dataValues.push(member.first_name.toLocaleLowerCase());
} }
break; break;
} }