refactor: not making calls to member's endpoint to get membership status (#1831)

* refactor: not making call to members endpoint to get membership status

* refactor: type for IProject
This commit is contained in:
Dakshesh Jain 2023-08-10 15:39:32 +05:30 committed by GitHub
parent 9ce85cdf21
commit 8c8668a3e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 108 additions and 116 deletions

View File

@ -8,10 +8,9 @@ import { mutate } from "swr";
// services // services
import projectService from "services/project.service"; import projectService from "services/project.service";
// hooks // hooks
import useProjectMembers from "hooks/use-project-members";
import useToast from "hooks/use-toast"; import useToast from "hooks/use-toast";
// ui // ui
import { CustomMenu, Loader, Tooltip } from "components/ui"; import { CustomMenu, Tooltip } from "components/ui";
// icons // icons
import { import {
CalendarDaysIcon, CalendarDaysIcon,
@ -46,11 +45,8 @@ export const SingleProjectCard: React.FC<ProjectCardProps> = ({
const { setToastAlert } = useToast(); const { setToastAlert } = useToast();
// fetching project members information const isOwner = project.member_role === 20;
const { members, hasJoined, isOwner, isMember } = useProjectMembers( const isMember = project.member_role === 15;
workspaceSlug as string,
project.id
);
const handleAddToFavorites = () => { const handleAddToFavorites = () => {
if (!workspaceSlug) return; if (!workspaceSlug) return;
@ -125,125 +121,119 @@ export const SingleProjectCard: React.FC<ProjectCardProps> = ({
return ( return (
<> <>
{members ? ( <div className="flex flex-col rounded-[10px] bg-custom-background-90 shadow">
<div className="flex flex-col rounded-[10px] bg-custom-background-90 shadow"> <Link href={`/${workspaceSlug as string}/projects/${project.id}/issues`}>
<a>
<div className="relative h-32 w-full rounded-t-[10px]">
<img
src={
project.cover_image ??
"https://images.unsplash.com/photo-1672243775941-10d763d9adef?ixlib=rb-4.0.3&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=1170&q=80"
}
alt={project.name}
className="absolute top-0 left-0 h-full w-full object-cover rounded-t-[10px]"
/>
<div className="absolute bottom-4 left-4 flex items-center gap-3 text-white">
{!project.is_member ? (
<button
type="button"
onClick={(e) => {
e.preventDefault();
e.stopPropagation();
setToJoinProject(project.id);
}}
className="flex cursor-pointer items-center gap-1 rounded bg-green-600 px-2 py-1 text-xs"
>
<PlusIcon className="h-3 w-3" />
<span>Select to Join</span>
</button>
) : (
<span className="cursor-default rounded bg-green-600 px-2 py-1 text-xs">
Member
</span>
)}
{project.is_favorite && (
<span className="grid h-6 w-9 cursor-default place-items-center rounded bg-orange-400">
<StarIcon className="h-3 w-3" />
</span>
)}
</div>
</div>
</a>
</Link>
<div className="flex h-full flex-col rounded-b-[10px] p-4 text-custom-text-200">
<Link href={`/${workspaceSlug as string}/projects/${project.id}/issues`}> <Link href={`/${workspaceSlug as string}/projects/${project.id}/issues`}>
<a> <a>
<div className="relative h-32 w-full rounded-t-[10px]"> <div className="flex items-center gap-1">
<img <h3 className="text-1.5xl font-medium text-custom-text-100">{project.name}</h3>
src={ {project.emoji ? (
project.cover_image ?? <span className="grid h-7 w-7 flex-shrink-0 place-items-center rounded uppercase">
"https://images.unsplash.com/photo-1672243775941-10d763d9adef?ixlib=rb-4.0.3&ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&auto=format&fit=crop&w=1170&q=80" {renderEmoji(project.emoji)}
} </span>
alt={project.name} ) : project.icon_prop ? (
className="absolute top-0 left-0 h-full w-full object-cover rounded-t-[10px]" renderEmoji(project.icon_prop)
/> ) : null}
<div className="absolute bottom-4 left-4 flex items-center gap-3 text-white">
{!hasJoined ? (
<button
type="button"
onClick={(e) => {
e.preventDefault();
e.stopPropagation();
setToJoinProject(project.id);
}}
className="flex cursor-pointer items-center gap-1 rounded bg-green-600 px-2 py-1 text-xs"
>
<PlusIcon className="h-3 w-3" />
<span>Select to Join</span>
</button>
) : (
<span className="cursor-default rounded bg-green-600 px-2 py-1 text-xs">
Member
</span>
)}
{project.is_favorite && (
<span className="grid h-6 w-9 cursor-default place-items-center rounded bg-orange-400">
<StarIcon className="h-3 w-3" />
</span>
)}
</div>
</div> </div>
<p className="mt-3.5 mb-7 break-words">
{truncateText(project.description ?? "", 100)}
</p>
</a> </a>
</Link> </Link>
<div className="flex h-full flex-col rounded-b-[10px] p-4 text-custom-text-200"> <div className="flex h-full items-end justify-between">
<Link href={`/${workspaceSlug as string}/projects/${project.id}/issues`}> <Tooltip
<a> tooltipContent={`Created at ${renderShortDateWithYearFormat(project.created_at)}`}
<div className="flex items-center gap-1"> position="bottom"
<h3 className="text-1.5xl font-medium text-custom-text-100">{project.name}</h3> >
{project.emoji ? ( <div className="flex cursor-default items-center gap-1.5 text-xs">
<span className="grid h-7 w-7 flex-shrink-0 place-items-center rounded uppercase"> <CalendarDaysIcon className="h-4 w-4" />
{renderEmoji(project.emoji)} {renderShortDateWithYearFormat(project.created_at)}
</span> </div>
) : project.icon_prop ? ( </Tooltip>
renderEmoji(project.icon_prop) {project.is_member ? (
) : null} <div className="flex items-center">
</div> {(isOwner || isMember) && (
<p className="mt-3.5 mb-7 break-words"> <Link href={`/${workspaceSlug}/projects/${project.id}/settings`}>
{truncateText(project.description ?? "", 100)} <a className="grid cursor-pointer place-items-center rounded p-1 duration-300 hover:bg-custom-background-90">
</p> <PencilIcon className="h-4 w-4" />
</a> </a>
</Link> </Link>
<div className="flex h-full items-end justify-between"> )}
<Tooltip <CustomMenu width="auto" verticalEllipsis>
tooltipContent={`Created at ${renderShortDateWithYearFormat(project.created_at)}`} {isOwner && (
position="bottom" <CustomMenu.MenuItem onClick={() => setDeleteProject(project.id)}>
>
<div className="flex cursor-default items-center gap-1.5 text-xs">
<CalendarDaysIcon className="h-4 w-4" />
{renderShortDateWithYearFormat(project.created_at)}
</div>
</Tooltip>
{hasJoined ? (
<div className="flex items-center">
{(isOwner || isMember) && (
<Link href={`/${workspaceSlug}/projects/${project.id}/settings`}>
<a className="grid cursor-pointer place-items-center rounded p-1 duration-300 hover:bg-custom-background-90">
<PencilIcon className="h-4 w-4" />
</a>
</Link>
)}
<CustomMenu width="auto" verticalEllipsis>
{isOwner && (
<CustomMenu.MenuItem onClick={() => setDeleteProject(project.id)}>
<span className="flex items-center justify-start gap-2">
<TrashIcon className="h-4 w-4" />
<span>Delete project</span>
</span>
</CustomMenu.MenuItem>
)}
{project.is_favorite ? (
<CustomMenu.MenuItem onClick={handleRemoveFromFavorites}>
<span className="flex items-center justify-start gap-2">
<StarIcon className="h-4 w-4" />
<span>Remove from favorites</span>
</span>
</CustomMenu.MenuItem>
) : (
<CustomMenu.MenuItem onClick={handleAddToFavorites}>
<span className="flex items-center justify-start gap-2">
<StarIcon className="h-4 w-4" />
<span>Add to favorites</span>
</span>
</CustomMenu.MenuItem>
)}
<CustomMenu.MenuItem onClick={handleCopyText}>
<span className="flex items-center justify-start gap-2"> <span className="flex items-center justify-start gap-2">
<LinkIcon className="h-4 w-4" /> <TrashIcon className="h-4 w-4" />
<span>Copy project link</span> <span>Delete project</span>
</span> </span>
</CustomMenu.MenuItem> </CustomMenu.MenuItem>
</CustomMenu> )}
</div> {project.is_favorite ? (
) : null} <CustomMenu.MenuItem onClick={handleRemoveFromFavorites}>
</div> <span className="flex items-center justify-start gap-2">
<StarIcon className="h-4 w-4" />
<span>Remove from favorites</span>
</span>
</CustomMenu.MenuItem>
) : (
<CustomMenu.MenuItem onClick={handleAddToFavorites}>
<span className="flex items-center justify-start gap-2">
<StarIcon className="h-4 w-4" />
<span>Add to favorites</span>
</span>
</CustomMenu.MenuItem>
)}
<CustomMenu.MenuItem onClick={handleCopyText}>
<span className="flex items-center justify-start gap-2">
<LinkIcon className="h-4 w-4" />
<span>Copy project link</span>
</span>
</CustomMenu.MenuItem>
</CustomMenu>
</div>
) : null}
</div> </div>
</div> </div>
) : ( </div>
<Loader>
<Loader.Item height="144px" />
</Loader>
)}
</> </>
); );
}; };

View File

@ -40,6 +40,8 @@ export interface IProject {
id: string; id: string;
identifier: string; identifier: string;
is_favorite: boolean; is_favorite: boolean;
is_member: boolean;
member_role: 5 | 10 | 15 | 20 | null;
issue_views_view: boolean; issue_views_view: boolean;
module_view: boolean; module_view: boolean;
name: string; name: string;