thunderstrike/plane
thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

fix: completed cycle validation , style: assignee count alignment fix (#1901)

Browse Source 
* style: assignee count alignment fix

* fix: completed cycle validation
This commit is contained in:
Anmol Singh Bhatia 2023-08-18 14:23:13 +05:30 committed by GitHub
parent c3c6ba9e34
commit 93fec2c678
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/app/components/cycles/single-cycle-card.tsx
View File

@ -45,7 +45,6 @@ type TSingleStatProps = {
handleDeleteCycle: () => void; handleDeleteCycle: () => void;
handleAddToFavorites: () => void; handleAddToFavorites: () => void;
handleRemoveFromFavorites: () => void; handleRemoveFromFavorites: () => void;
isCompleted?: boolean;
}; };
const stateGroups = [ const stateGroups = [
@ -82,7 +81,6 @@ export const SingleCycleCard: React.FC<TSingleStatProps> = ({
handleDeleteCycle, handleDeleteCycle,
handleAddToFavorites, handleAddToFavorites,
handleRemoveFromFavorites, handleRemoveFromFavorites,
isCompleted = false,
}) => { }) => {
const router = useRouter(); const router = useRouter();
const { workspaceSlug, projectId } = router.query; const { workspaceSlug, projectId } = router.query;
@ -90,6 +88,7 @@ export const SingleCycleCard: React.FC<TSingleStatProps> = ({
const { setToastAlert } = useToast(); const { setToastAlert } = useToast();
const cycleStatus = getDateRangeStatus(cycle.start_date, cycle.end_date); const cycleStatus = getDateRangeStatus(cycle.start_date, cycle.end_date);
const isCompleted = cycleStatus === "completed";
const endDate = new Date(cycle.end_date ?? ""); const endDate = new Date(cycle.end_date ?? "");
const startDate = new Date(cycle.start_date ?? ""); const startDate = new Date(cycle.start_date ?? "");

3
apps/app/components/cycles/single-cycle-list.tsx
View File

@ -34,7 +34,6 @@ type TSingleStatProps = {
handleDeleteCycle: () => void; handleDeleteCycle: () => void;
handleAddToFavorites: () => void; handleAddToFavorites: () => void;
handleRemoveFromFavorites: () => void; handleRemoveFromFavorites: () => void;
isCompleted?: boolean;
}; };
const stateGroups = [ const stateGroups = [
@ -113,7 +112,6 @@ export const SingleCycleList: React.FC<TSingleStatProps> = ({
handleDeleteCycle, handleDeleteCycle,
handleAddToFavorites, handleAddToFavorites,
handleRemoveFromFavorites, handleRemoveFromFavorites,
isCompleted = false,
}) => { }) => {
const router = useRouter(); const router = useRouter();
const { workspaceSlug, projectId } = router.query; const { workspaceSlug, projectId } = router.query;
@ -121,6 +119,7 @@ export const SingleCycleList: React.FC<TSingleStatProps> = ({
const { setToastAlert } = useToast(); const { setToastAlert } = useToast();
const cycleStatus = getDateRangeStatus(cycle.start_date, cycle.end_date); const cycleStatus = getDateRangeStatus(cycle.start_date, cycle.end_date);
const isCompleted = cycleStatus === "completed";
const endDate = new Date(cycle.end_date ?? ""); const endDate = new Date(cycle.end_date ?? "");
const startDate = new Date(cycle.start_date ?? ""); const startDate = new Date(cycle.start_date ?? "");

2
apps/app/components/ui/avatar.tsx
View File

@ -106,7 +106,7 @@ export const AssigneesList: React.FC<AsigneesListProps> = ({
))} ))}
{users.length > length ? ( {users.length > length ? (
<div className="-ml-3.5 relative h-6 w-6 rounded"> <div className="-ml-3.5 relative h-6 w-6 rounded">
<div className="grid place-items-center rounded bg-custom-background-80 text-xs capitalize h-6 w-6 text-custom-text-200 border-[0.5px] border-custom-border-300"> <div className="flex items-center rounded bg-custom-background-80 text-xs capitalize h-6 w-6 text-custom-text-200 border-[0.5px] border-custom-border-300">
<Icon iconName="add" className="text-xs !leading-3 -mr-0.5" /> <Icon iconName="add" className="text-xs !leading-3 -mr-0.5" />
{users.length - length} {users.length - length}
</div> </div>