diff --git a/admin/components/common/controller-input.tsx b/admin/components/common/controller-input.tsx index 8f2265954..0eb215095 100644 --- a/admin/components/common/controller-input.tsx +++ b/admin/components/common/controller-input.tsx @@ -2,10 +2,10 @@ import React, { useState } from "react"; import { Controller, Control } from "react-hook-form"; -// ui -import { Eye, EyeOff } from "lucide-react"; -import { Input } from "@plane/ui"; // icons +import { Eye, EyeOff } from "lucide-react"; +// ui +import { Input } from "@plane/ui"; // helpers import { cn } from "@/helpers/common.helper"; @@ -37,7 +37,9 @@ export const ControllerInput: React.FC = (props) => { return (
-

{label}

+

+ {label} {!required && "(optional)"} +

= (props) => { width={20} alt="GitHub Logo" /> - {text} + {text} ); }; diff --git a/web/components/account/auth-forms/auth-root.tsx b/web/components/account/auth-forms/auth-root.tsx index 0c0eb4755..8b9df7632 100644 --- a/web/components/account/auth-forms/auth-root.tsx +++ b/web/components/account/auth-forms/auth-root.tsx @@ -116,9 +116,6 @@ export const AuthRoot: FC = observer((props) => { }); }; - const isOAuthEnabled = - (instance?.config && (instance?.config?.is_google_enabled || instance?.config?.is_github_enabled)) || false; - return (
= observer((props) => { }} /> )} - {isOAuthEnabled && } - + +
); diff --git a/web/components/account/oauth/github-button.tsx b/web/components/account/oauth/github-button.tsx index 53fd6ed4f..317cebe31 100644 --- a/web/components/account/oauth/github-button.tsx +++ b/web/components/account/oauth/github-button.tsx @@ -33,7 +33,7 @@ export const GithubOAuthButton: FC = (props) => { width={20} alt="GitHub Logo" /> - {text} + {text} ); }; diff --git a/web/components/account/oauth/oauth-options.tsx b/web/components/account/oauth/oauth-options.tsx index b0a228eaf..960b48adf 100644 --- a/web/components/account/oauth/oauth-options.tsx +++ b/web/components/account/oauth/oauth-options.tsx @@ -4,10 +4,22 @@ import { GithubOAuthButton, GoogleOAuthButton } from "@/components/account"; // hooks import { useInstance } from "@/hooks/store"; -export const OAuthOptions: React.FC = observer(() => { +type TOAuthOptionProps = { + isSignUp?: boolean; +}; + +export const OAuthOptions: React.FC = observer((props) => { + const { isSignUp = false } = props; // hooks const { instance } = useInstance(); + const isOAuthEnabled = + (instance?.config && (instance?.config?.is_google_enabled || instance?.config?.is_github_enabled)) || false; + + if (!isOAuthEnabled) return null; + + const oauthProviderButtonText = `Sign ${isSignUp ? "up" : "in"} with`; + return ( <>
@@ -18,10 +30,10 @@ export const OAuthOptions: React.FC = observer(() => {
{instance?.config?.is_google_enabled && (
- +
)} - {instance?.config?.is_github_enabled && } + {instance?.config?.is_github_enabled && }
);