From ccbcfecc6d586d174e741d47920682e99cdbea90 Mon Sep 17 00:00:00 2001
From: Aaryan Khandelwal <65252264+aaryan610@users.noreply.github.com>
Date: Sun, 23 Jul 2023 22:13:09 +0530
Subject: [PATCH] fix: form not submitting on enter (#1613)

---
 .../app/components/core/modals/link-modal.tsx |  2 +-
 .../components/core/sidebar/links-list.tsx    | 60 +++++++++----------
 2 files changed, 30 insertions(+), 32 deletions(-)

diff --git a/apps/app/components/core/modals/link-modal.tsx b/apps/app/components/core/modals/link-modal.tsx
index b8d512a85..63a821dce 100644
--- a/apps/app/components/core/modals/link-modal.tsx
+++ b/apps/app/components/core/modals/link-modal.tsx
@@ -116,7 +116,7 @@ export const LinkModal: React.FC<Props> = ({ isOpen, handleClose, onFormSubmit }
                   </div>
                   <div className="mt-5 flex justify-end gap-2">
                     <SecondaryButton onClick={onClose}>Cancel</SecondaryButton>
-                    <PrimaryButton onClick={handleSubmit(onSubmit)} loading={isSubmitting}>
+                    <PrimaryButton type="submit" loading={isSubmitting}>
                       {isSubmitting ? "Adding Link..." : "Add Link"}
                     </PrimaryButton>
                   </div>
diff --git a/apps/app/components/core/sidebar/links-list.tsx b/apps/app/components/core/sidebar/links-list.tsx
index a0619b924..0d8a97298 100644
--- a/apps/app/components/core/sidebar/links-list.tsx
+++ b/apps/app/components/core/sidebar/links-list.tsx
@@ -1,5 +1,3 @@
-import Link from "next/link";
-
 // icons
 import { ArrowTopRightOnSquareIcon, LinkIcon, TrashIcon } from "@heroicons/react/24/outline";
 // helpers
@@ -30,14 +28,14 @@ export const LinksList: React.FC<Props> = ({ links, handleDeleteLink, userAuth }
         <div key={link.id} className="relative">
           {!isNotAllowed && (
             <div className="absolute top-1.5 right-1.5 z-[1] flex items-center gap-1">
-              <Link href={link.url}>
-                <a
-                  className="grid h-7 w-7 place-items-center rounded bg-custom-background-90 p-1 outline-none hover:bg-custom-background-80"
-                  target="_blank"
-                >
-                  <ArrowTopRightOnSquareIcon className="h-4 w-4 text-custom-text-200" />
-                </a>
-              </Link>
+              <a
+                href={link.url}
+                target="_blank"
+                rel="noopener noreferrer"
+                className="grid h-7 w-7 place-items-center rounded bg-custom-background-90 p-1 outline-none hover:bg-custom-background-80"
+              >
+                <ArrowTopRightOnSquareIcon className="h-4 w-4 text-custom-text-200" />
+              </a>
               <button
                 type="button"
                 className="grid h-7 w-7 place-items-center rounded bg-custom-background-90 p-1 text-red-500 outline-none duration-300 hover:bg-red-500/20"
@@ -47,27 +45,27 @@ export const LinksList: React.FC<Props> = ({ links, handleDeleteLink, userAuth }
               </button>
             </div>
           )}
-          <Link href={link.url}>
-            <a
-              className="relative flex gap-2 rounded-md bg-custom-background-90 p-2"
-              target="_blank"
-            >
-              <div className="mt-0.5">
-                <LinkIcon className="h-3.5 w-3.5" />
-              </div>
-              <div>
-                <h5 className="w-4/5 break-words">{link.title}</h5>
-                <p className="mt-0.5 text-custom-text-200">
-                  Added {timeAgo(link.created_at)}
-                  <br />
-                  by{" "}
-                  {link.created_by_detail.is_bot
-                    ? link.created_by_detail.first_name + " Bot"
-                    : link.created_by_detail.email}
-                </p>
-              </div>
-            </a>
-          </Link>
+          <a
+            href={link.url}
+            target="_blank"
+            rel="noopener noreferrer"
+            className="relative flex gap-2 rounded-md bg-custom-background-90 p-2"
+          >
+            <div className="mt-0.5">
+              <LinkIcon className="h-3.5 w-3.5" />
+            </div>
+            <div>
+              <h5 className="w-4/5 break-words">{link.title}</h5>
+              <p className="mt-0.5 text-custom-text-200">
+                Added {timeAgo(link.created_at)}
+                <br />
+                by{" "}
+                {link.created_by_detail.is_bot
+                  ? link.created_by_detail.first_name + " Bot"
+                  : link.created_by_detail.email}
+              </p>
+            </div>
+          </a>
         </div>
       ))}
     </>