chore: onboarding workflow in authentication (#1281)

2023-06-13 14:37:25 +05:30 · 2023-06-13 14:37:25 +05:30 · f774603b7f
commit f774603b7f
parent 15b5db0cae
5 changed files with 159 additions and 129 deletions
--- a/apps/app/components/account/email-code-form.tsx
+++ b/apps/app/components/account/email-code-form.tsx
@ -16,7 +16,7 @@ type EmailCodeFormValues = {
  token?: string;
 };

-export const EmailCodeForm = ({ onSuccess }: any) => {
+export const EmailCodeForm = ({ handleSignIn }: any) => {
  const [codeSent, setCodeSent] = useState(false);
  const [codeResent, setCodeResent] = useState(false);
  const [isCodeResending, setIsCodeResending] = useState(false);
@ -66,7 +66,12 @@ export const EmailCodeForm = ({ onSuccess }: any) => {

  const handleSignin = async (formData: EmailCodeFormValues) => {
    setIsLoading(true);
-    await authenticationService.magicSignIn(formData).catch((error) => {
+    await authenticationService
+      .magicSignIn(formData)
+      .then((response) => {
+        handleSignIn(response);
+      })
+      .catch((error) => {
        setIsLoading(false);
        setToastAlert({
          title: "Oops!",
@ -75,7 +80,7 @@ export const EmailCodeForm = ({ onSuccess }: any) => {
        });
        setError("token" as keyof EmailCodeFormValues, {
          type: "manual",
-        message: error.error,
+          message: error?.error,
        });
      });
  };
--- a/apps/app/components/account/github-login-button.tsx
+++ b/apps/app/components/account/github-login-button.tsx
@ -35,12 +35,12 @@ export const GithubLoginButton: FC<GithubLoginButtonProps> = (props) => {
  }, []);

  return (
-    <div className="w-full px-1">
+    <div className="w-full flex justify-center items-center px-[3px]">
      <Link
        href={`https://github.com/login/oauth/authorize?client_id=${NEXT_PUBLIC_GITHUB_ID}&redirect_uri=${loginCallBackURL}&scope=read:user,user:email`}
      >
-        <button className="flex w-full items-center justify-center gap-3 rounded-md border border-brand-base p-2 text-sm font-medium text-brand-secondary duration-300 hover:bg-brand-surface-2">
-          <Image src={githubImage} height={22} width={22} color="#000" alt="GitHub Logo" />
+        <button className="flex w-full items-center justify-center gap-3 rounded border border-brand-base p-2 text-sm font-medium text-brand-secondary duration-300 hover:bg-brand-surface-2">
+          <Image src={githubImage} height={20} width={20} color="#000" alt="GitHub Logo" />
          <span>Sign In with Github</span>
        </button>
      </Link>
--- a/apps/app/components/account/google-login.tsx
+++ b/apps/app/components/account/google-login.tsx
@ -47,7 +47,11 @@ export const GoogleLoginButton: FC<IGoogleLoginButton> = (props) => {
  return (
    <>
      <Script src="https://accounts.google.com/gsi/client" async defer onLoad={loadScript} />
-      <div className="overflow-hidden rounded" id="googleSignInButton" ref={googleSignInButton} />
+      <div
+        className="overflow-hidden rounded w-full flex justify-center items-center"
+        id="googleSignInButton"
+        ref={googleSignInButton}
+      />
    </>
  );
 };
--- a/apps/app/pages/index.tsx
+++ b/apps/app/pages/index.tsx
@ -40,12 +40,14 @@ const HomePage: NextPage = () => {
      } else {
        throw Error("Cant find credentials");
      }
-    } catch (error) {
+    } catch (error: any) {
      console.log(error);
      setToastAlert({
        title: "Error signing in!",
        type: "error",
-        message: "Something went wrong. Please try again later or contact the support team.",
+        message:
+          error?.error ||
+          "Something went wrong. Please try again later or contact the support team.",
      });
    }
  };
@ -63,27 +65,44 @@ const HomePage: NextPage = () => {
      } else {
        throw Error("Cant find credentials");
      }
-    } catch (error) {
+    } catch (error: any) {
      console.log(error);
      setToastAlert({
        title: "Error signing in!",
        type: "error",
-        message: "Something went wrong. Please try again later or contact the support team.",
+        message:
+          error?.error ||
+          "Something went wrong. Please try again later or contact the support team.",
      });
    }
  };

  const handleEmailPasswordSignIn = async (response: any) => {
    try {
-      if (response) {
-        mutateUser();
-      }
-    } catch (error) {
+      if (response) mutateUser();
+    } catch (error: any) {
      console.log(error);
      setToastAlert({
        title: "Error signing in!",
        type: "error",
-        message: "Something went wrong. Please try again later or contact the support team.",
+        message:
+          error?.error ||
+          "Something went wrong. Please try again later or contact the support team.",
+      });
+    }
+  };
+
+  const handleEmailCodeSignIn = async (response: any) => {
+    try {
+      if (response) mutateUser();
+    } catch (error: any) {
+      console.log(error);
+      setToastAlert({
+        title: "Error signing in!",
+        type: "error",
+        message:
+          error?.error ||
+          "Something went wrong. Please try again later or contact the support team.",
      });
    }
  };
@ -91,9 +110,12 @@ const HomePage: NextPage = () => {
  return (
    <DefaultLayout>
      {isLoading ? (
-        <div className="grid h-screen place-items-center">
+        <div className="flex flex-col gap-3 w-full h-screen justify-center items-center">
+          <div>
            <Spinner />
          </div>
+          {/* <div className="text-gray-500">Validating authentication</div> */}
+        </div>
      ) : (
        <div className="flex h-screen w-full items-center justify-center overflow-auto">
          <div className="flex min-h-full w-full flex-col justify-center py-12 px-6 lg:px-8">
@ -108,16 +130,14 @@ const HomePage: NextPage = () => {
              <div className="flex flex-col rounded-[10px] bg-brand-base shadow-md">
                {parseInt(process.env.NEXT_PUBLIC_ENABLE_OAUTH || "0") ? (
                  <>
-                    <EmailCodeForm />
+                    <EmailCodeForm handleSignIn={handleEmailCodeSignIn} />
                    <div className="flex flex-col items-center justify-center gap-3 border-t border-brand-base py-5 px-5">
                      <GoogleLoginButton handleSignIn={handleGoogleSignIn} />
                      <GithubLoginButton handleSignIn={handleGithubSignIn} />
                    </div>
                  </>
                ) : (
-                  <>
                  <EmailPasswordForm handleSignIn={handleEmailPasswordSignIn} />
-                  </>
                )}
              </div>
            </div>
--- a/apps/app/pages/onboarding.tsx
+++ b/apps/app/pages/onboarding.tsx
@ -1,9 +1,6 @@
 import { useState } from "react";
-
+// next imports
 import Router from "next/router";
-
-import { mutate } from "swr";
-
 // services
 import userService from "services/user.service";
 import workspaceService from "services/workspace.service";
@ -11,7 +8,6 @@ import workspaceService from "services/workspace.service";
 import useUserAuth from "hooks/use-user-auth";
 // layouts
 import DefaultLayout from "layouts/default-layout";
-import { UserAuthorizationLayout } from "layouts/auth-layout/user-authorization-wrapper";
 // components
 import {
  InviteMembers,
@ -26,9 +22,6 @@ import { PrimaryButton, Spinner } from "components/ui";
 import { ONBOARDING_CARDS } from "constants/workspace";
 // types
 import type { NextPage } from "next";
-import { ICurrentUserResponse } from "types";
-// fetch-keys
-import { CURRENT_USER } from "constants/fetch-keys";

 const Onboarding: NextPage = () => {
  const [step, setStep] = useState(1);
@ -37,11 +30,16 @@ const Onboarding: NextPage = () => {

  const [workspace, setWorkspace] = useState();

-  const { user, mutateUser } = useUserAuth("onboarding");
+  const { user, isLoading: userLoading, mutateUser } = useUserAuth("onboarding");

  return (
-    <UserAuthorizationLayout>
    <DefaultLayout>
+      {userLoading ? (
+        <div className="grid h-screen place-items-center">
+          <Spinner />
+        </div>
+      ) : (
+        <>
          {isLoading ? (
            <div className="grid h-screen place-items-center">
              <Spinner />
@ -58,7 +56,9 @@ const Onboarding: NextPage = () => {
                  ) : step === 2 ? (
                    <Workspace setStep={setStep} setWorkspace={setWorkspace} user={user} />
                  ) : (
+                    step === 3 && (
                      <InviteMembers setStep={setStep} workspace={workspace} user={user} />
+                    )
                  )}
                </div>
              ) : (
@ -73,7 +73,7 @@ const Onboarding: NextPage = () => {
                    ) : step === 7 ? (
                      <OnboardingCard data={ONBOARDING_CARDS.module} gradient />
                    ) : (
-                    <OnboardingCard data={ONBOARDING_CARDS.commandMenu} />
+                      step === 8 && <OnboardingCard data={ONBOARDING_CARDS.commandMenu} />
                    )}
                    <div className="mx-auto flex h-1/4 items-end lg:w-1/2">
                      <PrimaryButton
@ -138,8 +138,9 @@ const Onboarding: NextPage = () => {
              </div>
            </div>
          )}
+        </>
+      )}
    </DefaultLayout>
-    </UserAuthorizationLayout>
  );
 };