Roll chromium to 508268 (#1019)

This gets us:

- Plural metrics names https://crrev.com/507885
- TargetInfoChanged on URL changes https://crrev.com/508049
- Sending proper resource types for requests https://crrev.com/667504

Fixes #734
This commit is contained in:
JoelEinbinder 2017-10-12 01:17:06 -07:00 committed by Andrey Lushnikov
parent c893bf3684
commit 0426e3c068
4 changed files with 15 additions and 15 deletions

View File

@ -671,10 +671,10 @@ If there's no element matching `selector`, the method throws an error.
#### page.getMetrics()
- returns: <[Object]> Object containing metrics as key/value pairs.
- `Timestamp` <[number]> The timestamp when the metrics sample was taken.
- `DocumentCount` <[number]> Number of documents in the page.
- `FrameCount` <[number]> Number of frames in the page.
- `JSEventListenerCount` <[number]> Number of events in the page.
- `NodeCount` <[number]> Number of DOM nodes in the page.
- `Documents` <[number]> Number of documents in the page.
- `Frames` <[number]> Number of frames in the page.
- `JSEventListeners` <[number]> Number of events in the page.
- `Nodes` <[number]> Number of DOM nodes in the page.
- `LayoutCount` <[number]> Total number of full or partial page layout.
- `RecalcStyleCount` <[number]> Total number of page style recalculations.
- `LayoutDuration` <[number]> Combined durations of all page layouts.

View File

@ -832,10 +832,10 @@ class Page extends EventEmitter {
/** @type {!Set<string>} */
const supportedMetrics = new Set([
'Timestamp',
'DocumentCount',
'FrameCount',
'JSEventListenerCount',
'NodeCount',
'Documents',
'Frames',
'JSEventListeners',
'Nodes',
'LayoutCount',
'RecalcStyleCount',
'LayoutDuration',

View File

@ -34,7 +34,7 @@
"ws": "^3.0.0"
},
"puppeteer": {
"chromium_revision": "507565"
"chromium_revision": "508268"
},
"devDependencies": {
"@types/debug": "0.0.30",

View File

@ -796,10 +796,10 @@ describe('Page', function() {
function checkMetrics(metrics) {
const metricsToCheck = new Set([
'Timestamp',
'DocumentCount',
'FrameCount',
'JSEventListenerCount',
'NodeCount',
'Documents',
'Frames',
'JSEventListeners',
'Nodes',
'LayoutCount',
'RecalcStyleCount',
'LayoutDuration',