thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(test): remove --firefox-status flag from tests (#3956)

Browse Source 
The [IsPuppeteerFirefoxReady?](https://aslushnikov.github.io/ispuppeteerfirefoxready/)
website now has its own script to compute test and api coverage.
This commit is contained in:
Andrey Lushnikov 2019-02-08 13:29:13 -08:00 committed by GitHub
parent 07b43ff29a
commit 0bb657cb26
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
test/test.js
View File

@ -78,7 +78,19 @@ const CHROMIUM_NO_COVERAGE = new Set([
'securityDetails.validTo',
]);
if (process.env.BROWSER !== 'firefox') {
if (process.env.BROWSER === 'firefox') {
testRunner.addTestDSL('it_fails_ffox', 'skip');
testRunner.addSuiteDSL('describe_fails_ffox', 'skip');
describe('Firefox', () => {
require('./puppeteer.spec.js').addTests({
product: 'Firefox',
puppeteer: require('../experimental/puppeteer-firefox'),
Errors: require('../experimental/puppeteer-firefox/Errors'),
DeviceDescriptors: utils.requireRoot('DeviceDescriptors'),
testRunner,
});
});
} else {
testRunner.addTestDSL('it_fails_ffox', 'run');
testRunner.addSuiteDSL('describe_fails_ffox', 'run');
describe('Chromium', () => {
@ -92,37 +104,6 @@ if (process.env.BROWSER !== 'firefox') {
if (process.env.COVERAGE)
utils.recordAPICoverage(testRunner, require('../lib/api'), CHROMIUM_NO_COVERAGE);
});
} else {
const FFOX_SKIPPED_TESTS = Symbol('FFOX_SKIPPED_TESTS');
testRunner.addTestDSL('it_fails_ffox', 'skip', FFOX_SKIPPED_TESTS);
testRunner.addSuiteDSL('describe_fails_ffox', 'skip', FFOX_SKIPPED_TESTS);
describe('Firefox', () => {
require('./puppeteer.spec.js').addTests({
product: 'Firefox',
puppeteer: require('../experimental/puppeteer-firefox'),
Errors: require('../experimental/puppeteer-firefox/Errors'),
DeviceDescriptors: utils.requireRoot('DeviceDescriptors'),
testRunner,
});
});
if (process.argv.indexOf('--firefox-status') !== -1) {
const allTests = testRunner.tests();
const ffoxTests = allTests.filter(test => {
if (test.comment === FFOX_SKIPPED_TESTS)
return false;
for (let suite = test.suite; suite; suite = suite.parentSuite) {
if (suite.comment === FFOX_SKIPPED_TESTS)
return false;
}
return true;
});
console.log(JSON.stringify({
allTests: allTests.length,
firefoxTests: ffoxTests.length
}));
process.exit(0);
}
}
if (process.env.CI && testRunner.hasFocusedTestsOrSuites()) {