thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(chromium): roll Chromium to r682225 (#4844)

Browse Source 
This roll includes:
- https://crrev.com/681997 - Turn on default SiteInstance by default.

The SiteInstance by default was breaking "devtools: true" option, so
there's a new feature we disable now by default.

This keeps pressuring us towards OOPIF support since that's an
inevitable future.
This commit is contained in:
Andrey Lushnikov 2019-08-14 15:25:55 -07:00 committed by GitHub
parent ff6d2a33f3
commit 0e0a67916d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Launcher.js
View File

@ -46,9 +46,8 @@ const DEFAULT_ARGS = [
'--disable-default-apps', '--disable-default-apps',
'--disable-dev-shm-usage', '--disable-dev-shm-usage',
'--disable-extensions', '--disable-extensions',
// TODO: Support OOOPIF. @see https://github.com/GoogleChrome/puppeteer/issues/2548
// BlinkGenPropertyTrees disabled due to crbug.com/937609 // BlinkGenPropertyTrees disabled due to crbug.com/937609
'--disable-features=site-per-process,TranslateUI,BlinkGenPropertyTrees', '--disable-features=TranslateUI,BlinkGenPropertyTrees',
'--disable-hang-monitor', '--disable-hang-monitor',
'--disable-ipc-flooding-protection', '--disable-ipc-flooding-protection',
'--disable-popup-blocking', '--disable-popup-blocking',

2
package.json
View File

@ -8,7 +8,7 @@
"node": ">=6.4.0" "node": ">=6.4.0"
}, },
"puppeteer": { "puppeteer": {
"chromium_revision": "681777" "chromium_revision": "682225"
}, },
"scripts": { "scripts": {
"unit": "node test/test.js", "unit": "node test/test.js",

12
test/headful.spec.js
View File

@ -86,7 +86,8 @@ module.exports.addTests = function({testRunner, expect, puppeteer, defaultBrowse
await rmAsync(userDataDir).catch(e => {}); await rmAsync(userDataDir).catch(e => {});
expect(cookie).toBe('foo=true'); expect(cookie).toBe('foo=true');
}); });
it('OOPIF: should report google.com frame', async({server}) => { // TODO: Support OOOPIF. @see https://github.com/GoogleChrome/puppeteer/issues/2548
xit('OOPIF: should report google.com frame', async({server}) => {
// https://google.com is isolated by default in Chromium embedder. // https://google.com is isolated by default in Chromium embedder.
const browser = await puppeteer.launch(headfulOptions); const browser = await puppeteer.launch(headfulOptions);
const page = await browser.newPage(); const page = await browser.newPage();
@ -116,6 +117,15 @@ module.exports.addTests = function({testRunner, expect, puppeteer, defaultBrowse
await page.click('body'); await page.click('body');
await browser.close(); await browser.close();
}); });
it('should open devtools when "devtools: true" option is given', async({server}) => {
const browser = await puppeteer.launch({...headfulOptions, devtools: true});
const context = await browser.createIncognitoBrowserContext();
await Promise.all([
context.newPage(),
context.waitForTarget(target => target.url().startsWith('devtools://')),
]);
await browser.close();
});
}); });
describe('Page.bringToFront', function() { describe('Page.bringToFront', function() {