thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(pipe): make sure the pipe is not stuck (#2933)

Browse Source 
When process is spawned with the 'pipe' set for stdout and stderr, Node expects these streams to be actually dispatched. If we don't, write into pipe becomes blocking and chrome stalls.

We work around that via setting 'ignore' to the stdin, stdout and stderr when the pipe communication channel is used.
This commit is contained in:
Pavel Feldman 2018-07-24 11:36:35 -07:00 committed by Andrey Lushnikov
parent ca99a67aad
commit 14e69d189c
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Launcher.js
View File

@ -111,9 +111,7 @@ class Launcher {
chromeArguments.push(...options.args); chromeArguments.push(...options.args);
const usePipe = chromeArguments.includes('--remote-debugging-pipe'); const usePipe = chromeArguments.includes('--remote-debugging-pipe');
const stdio = ['pipe', 'pipe', 'pipe']; const stdio = usePipe ? ['ignore', 'ignore', 'ignore', 'pipe', 'pipe'] : ['pipe', 'pipe', 'pipe'];
if (usePipe)
stdio.push('pipe', 'pipe');
const chromeProcess = childProcess.spawn( const chromeProcess = childProcess.spawn(
chromeExecutable, chromeExecutable,
chromeArguments, chromeArguments,