thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(Chromium): roll chromium to r543305 (#2196)

Browse Source 
This roll contains a [fix](https://chromium-review.googlesource.com/c/chromium/src/+/963302) for boundingBox not forcing a layout, and the patch contains a corresponding test.
This commit is contained in:
JoelEinbinder 2018-03-15 16:37:10 -07:00 committed by Andrey Lushnikov
parent d79eb70267
commit 309cafb876
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -36,7 +36,7 @@
"ws": "^3.0.0" "ws": "^3.0.0"
}, },
"puppeteer": { "puppeteer": {
"chromium_revision": "538022" "chromium_revision": "543305"
}, },
"devDependencies": { "devDependencies": {
"@types/debug": "0.0.30", "@types/debug": "0.0.30",

8
test/test.js
View File

@ -2068,6 +2068,14 @@ describe('Page', function() {
const element = await page.$('div'); const element = await page.$('div');
expect(await element.boundingBox()).toBe(null); expect(await element.boundingBox()).toBe(null);
}); });
it('should force a layout', async({page, server}) => {
await page.setViewport({ width: 500, height: 500 });
await page.setContent('<div style="width: 100px; height: 100px">hello</div>');
const elementHandle = await page.$('div');
await page.evaluate(element => element.style.height = '200px', elementHandle);
const box = await elementHandle.boundingBox();
expect(box).toEqual({ x: 8, y: 8, width: 100, height: 200 });
});
}); });
describe('ElementHandle.contentFrame', function() { describe('ElementHandle.contentFrame', function() {