thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "chore(tests): redirect debugError to the output category of tests (#2969)" (#2987)

Browse Source 
This reverts commit c5fe1dbdbb.
This commit is contained in:
Andrey Lushnikov 2018-07-30 16:41:39 -07:00 committed by GitHub
parent c5fe1dbdbb
commit 392d3b94bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Tracing.js
View File

@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
const {helper, assert, debugError} = require('./helper');
const {helper, assert} = require('./helper');
const fs = require('fs');
const openAsync = helper.promisify(fs.open);
@ -89,8 +89,6 @@ class Tracing {
let resultBuffer = null;
try {
resultBuffer = Buffer.concat(bufs);
} catch (error) {
debugError(error);
} finally {
return resultBuffer;
}

9
test/test.js
View File

@ -22,7 +22,7 @@ const GOLDEN_DIR = path.join(__dirname, 'golden');
const OUTPUT_DIR = path.join(__dirname, 'output');
const {TestRunner, Reporter, Matchers} = require('../utils/testrunner/');
const {helper, assert, debugError} = require('../lib/helper');
const {helper, assert} = require('../lib/helper');
if (process.env.COVERAGE)
helper.recordPublicAPICoverage();
@ -116,16 +116,9 @@ describe('Page', function() {
const rl = require('readline').createInterface({input: state.browser.process().stderr});
test.output = '';
rl.on('line', onLine);
const enableDebugError = !debugError.enabled;
if (enableDebugError) {
require('debug').enable(debugError.namespace);
debugError.log = onLine;
}
state.tearDown = () => {
rl.removeListener('line', onLine);
rl.close();
if (enableDebugError)
debugError.log = () => undefined;
};
function onLine(line) {
test.output += line + '\n';