thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(tests): ensure all tests honour BINARY envvar (#8092)

Browse Source 
Without this patch, two tests ignore the BINARY envvar, and fail when not using
the embedded chromium, unless the chromium executable path is defined via
PUPPETEER_EXECUTABLE_PATH, which should not be considered according to the
docs.
This commit is contained in:
Martina Ferrari 2022-03-03 14:05:49 +00:00 committed by GitHub
parent 8eac7c946e
commit 3b8b9adde5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/launcher.spec.ts
View File

@ -708,9 +708,9 @@ describe('Launcher specs', function () {
itFailsFirefox( itFailsFirefox(
'should be able to connect to the same page simultaneously', 'should be able to connect to the same page simultaneously',
async () => { async () => {
const { puppeteer } = getTestState(); const { puppeteer, defaultBrowserOptions } = getTestState();
const browserOne = await puppeteer.launch(); const browserOne = await puppeteer.launch(defaultBrowserOptions);
const browserTwo = await puppeteer.connect({ const browserTwo = await puppeteer.connect({
browserWSEndpoint: browserOne.wsEndpoint(), browserWSEndpoint: browserOne.wsEndpoint(),
}); });
@ -726,8 +726,8 @@ describe('Launcher specs', function () {
} }
); );
it('should be able to reconnect', async () => { it('should be able to reconnect', async () => {
const { puppeteer, server } = getTestState(); const { puppeteer, server, defaultBrowserOptions } = getTestState();
const browserOne = await puppeteer.launch(); const browserOne = await puppeteer.launch(defaultBrowserOptions);
const browserWSEndpoint = browserOne.wsEndpoint(); const browserWSEndpoint = browserOne.wsEndpoint();
const pageOne = await browserOne.newPage(); const pageOne = await browserOne.newPage();
await pageOne.goto(server.EMPTY_PAGE); await pageOne.goto(server.EMPTY_PAGE);