chore: update Windows skipped tests. (#6133)

The headful one I'm permanently skipping as I don't know what the issue is and I can't debug without getting my hands on a Windows machine. If anyone has one or is able to help, that'd be great!

The other I'm deferring another month and will ping the FF folks :)
This commit is contained in:
Jack Franklin 2020-07-01 11:28:13 +01:00 committed by GitHub
parent 9f198626f8
commit 3c0dc45e47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 9 deletions

View File

@ -22,7 +22,7 @@ import expect from 'expect';
import { import {
getTestState, getTestState,
describeChromeOnly, describeChromeOnly,
itFailsWindowsUntilDate, itFailsWindows,
} from './mocha-utils'; } from './mocha-utils';
import rimraf from 'rimraf'; import rimraf from 'rimraf';
@ -91,15 +91,10 @@ describeChromeOnly('headful tests', function () {
expect(pages).toEqual(['about:blank']); expect(pages).toEqual(['about:blank']);
await browser.close(); await browser.close();
}); });
itFailsWindowsUntilDate( itFailsWindows(
/* We have deferred fixing this test on Windows in favour of
* getting all other Windows tests running on CI. Putting this
* date in to force us to come back and debug properly in the
* future.
*/
new Date('2020-07-01'),
'headless should be able to read cookies written by headful', 'headless should be able to read cookies written by headful',
async () => { async () => {
/* Needs investigation into why but this fails consistently on Windows CI. */
const { server, puppeteer } = getTestState(); const { server, puppeteer } = getTestState();
const userDataDir = await mkdtempAsync(TMP_FOLDER); const userDataDir = await mkdtempAsync(TMP_FOLDER);

View File

@ -472,7 +472,7 @@ describe('Launcher specs', function () {
* properly with help from the Mozilla folks. * properly with help from the Mozilla folks.
*/ */
itFailsWindowsUntilDate( itFailsWindowsUntilDate(
new Date('2020-07-01'), new Date('2020-07-30'),
'should be able to launch Firefox', 'should be able to launch Firefox',
async () => { async () => {
const { puppeteer } = getTestState(); const { puppeteer } = getTestState();

View File

@ -170,6 +170,13 @@ export const itFailsWindowsUntilDate = (
return it(description, body); return it(description, body);
}; };
export const itFailsWindows = (description: string, body: Mocha.Func) => {
if (os.platform() === 'win32') {
return xit(description, body);
}
return it(description, body);
};
export const describeFailsFirefox = ( export const describeFailsFirefox = (
description: string, description: string,
body: (this: Mocha.Suite) => void body: (this: Mocha.Suite) => void