thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: use named import for devtools-protocol module (#9511)

Browse Source 
<!-- Thanks for submitting a pull request! Please provide enough
information so that others can review your pull request. -->

**What kind of change does this PR introduce?**
types fix

**Did you add tests for your changes?**
No

**If relevant, did you update the documentation?**
Not relevant

**Summary**
I am updating `import`s of `devtools-protocol` to always use named
import instead of the default.
For some reason, typescript doesn't understand when it is imported as
default.

```
node_modules/puppeteer-core/lib/esm/puppeteer/common/TargetManager.d.ts:23:59 - error TS2694: Namespace '"/Users/kyrylo/pacakge/node_modules/puppeteer-core/node_modules/devtools-protocol/types/protocol"' has no exported member 'Target'.

23 export declare type TargetFactory = (targetInfo: Protocol.Target.TargetInfo, session?: CDPSession) => Target;
                                                             ~~~~~~


Found 1 error in node_modules/puppeteer-core/lib/esm/puppeteer/common/TargetManager.d.ts:23
```

**Does this PR introduce a breaking change?**
No
<!-- If this PR introduces a breaking change, please describe the impact
and a migration path for existing applications. -->

**Other information**
I am updating `import`s of `devtools-protocol` to always use named
import instead of the default.
This commit is contained in:
Kyrylo 2023-01-17 13:34:57 +02:00 committed by GitHub
parent ac132a6a03
commit 3e80667048
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/puppeteer-core/src/common/ChromeTargetManager.ts
View File

@ -14,7 +14,7 @@
* limitations under the License.
*/
import Protocol from 'devtools-protocol';
import {Protocol} from 'devtools-protocol';
import {assert} from '../util/assert.js';
import {CDPSession, Connection} from './Connection.js';
import {EventEmitter} from './EventEmitter.js';

2
packages/puppeteer-core/src/common/FirefoxTargetManager.ts
View File

@ -14,7 +14,7 @@
* limitations under the License.
*/
import Protocol from 'devtools-protocol';
import {Protocol} from 'devtools-protocol';
import {assert} from '../util/assert.js';
import {CDPSession, Connection} from './Connection.js';
import {Target} from './Target.js';

2
packages/puppeteer-core/src/common/TargetManager.ts
View File

@ -14,7 +14,7 @@
* limitations under the License.
*/
import Protocol from 'devtools-protocol';
import {Protocol} from 'devtools-protocol';
import {CDPSession} from './Connection.js';
import {EventEmitter} from './EventEmitter.js';
import {Target} from './Target.js';

2
test/src/launcher.spec.ts
View File

@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import Protocol from 'devtools-protocol';
import {Protocol} from 'devtools-protocol';
import expect from 'expect';
import fs from 'fs';
import os from 'os';

2
test/src/mocha-utils.ts
View File

@ -14,7 +14,7 @@
* limitations under the License.
*/
import Protocol from 'devtools-protocol';
import {Protocol} from 'devtools-protocol';
import expect from 'expect';
import * as fs from 'fs';
import * as path from 'path';