fix(Page.getMetrics): do not report a few metrics (#1001)
A few of the reported metrics in the Page.getMetrics are already reported with lifecycle events. This patch excludes these metrics for now.
This commit is contained in:
parent
b82d3197ed
commit
464b6a9616
@ -663,9 +663,6 @@ If there's no element matching `selector`, the method throws an error.
|
||||
- `TaskDuration` <[number]> Combined duration of all tasks performed by the browser.
|
||||
- `JSHeapUsedSize` <[number]> Used JavaScript heap size.
|
||||
- `JSHeapTotalSize` <[number]> Total JavaScript heap size.
|
||||
- `FirstMeaningfulPaint` <[number]> Timestamp of the first meaningful paint event.
|
||||
- `DomContentLoaded` <[number]> Timestamp of the DOM content loaded event.
|
||||
- `NavigationStart` <[number]> Timestamp of the navigation start event.
|
||||
|
||||
> **NOTE** All timestamps are in monotonic time: monotonically increasing time in seconds since an arbitrary point in the past.
|
||||
|
||||
|
@ -824,9 +824,6 @@ const supportedMetrics = new Set([
|
||||
'TaskDuration',
|
||||
'JSHeapUsedSize',
|
||||
'JSHeapTotalSize',
|
||||
'FirstMeaningfulPaint',
|
||||
'DomContentLoaded',
|
||||
'NavigationStart',
|
||||
]);
|
||||
|
||||
/** @enum {string} */
|
||||
|
@ -777,9 +777,6 @@ describe('Page', function() {
|
||||
'TaskDuration',
|
||||
'JSHeapUsedSize',
|
||||
'JSHeapTotalSize',
|
||||
'FirstMeaningfulPaint',
|
||||
'DomContentLoaded',
|
||||
'NavigationStart',
|
||||
]);
|
||||
for (const name in metrics) {
|
||||
expect(metricsToCheck.has(name)).toBeTruthy();
|
||||
|
Loading…
Reference in New Issue
Block a user