thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: fix serviceWorker test flakiness (#2195)

Browse Source 
This patch starts waiting on serviceWorker registration.
This commit is contained in:
Andrey Lushnikov 2018-03-14 17:55:12 -07:00 committed by GitHub
parent 625c7ebdda
commit 4b7fbf8ee0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/assets/serviceworkers/fetch/sw.html
View File

@ -1,4 +1,4 @@
<link rel="stylesheet" href="./style.css"> <link rel="stylesheet" href="./style.css">
<script> <script>
navigator.serviceWorker.register('sw.js'); window.registrationPromise = navigator.serviceWorker.register('sw.js');
</script> </script>

1
test/test.js
View File

@ -2862,6 +2862,7 @@ describe('Page', function() {
// Load and re-load to make sure serviceworker is installed and running. // Load and re-load to make sure serviceworker is installed and running.
await page.goto(server.PREFIX + '/serviceworkers/fetch/sw.html', {waitUntil: 'networkidle2'}); await page.goto(server.PREFIX + '/serviceworkers/fetch/sw.html', {waitUntil: 'networkidle2'});
await page.evaluate(async() => await window.registrationPromise);
await page.reload(); await page.reload();
expect(responses.size).toBe(2); expect(responses.size).toBe(2);