thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: re-enable tests for Firefox related to fixed Input.dispatchMouseEvent issues (#7776)

Browse Source 
Issues: #7115
This commit is contained in:
Henrik Skupin 2021-11-19 08:50:31 +01:00 committed by GitHub
parent 9f9b4ed72a
commit 4c3caaa3f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 32 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
test/click.spec.ts
View File

@ -238,8 +238,7 @@ describe('Page.click', function () {
)
).toBe('clicked');
});
// See https://github.com/puppeteer/puppeteer/issues/7175
itFailsFirefox('should double click the button', async () => {
it('should double click the button', async () => {
const { page, server } = getTestState();
await page.goto(server.PREFIX + '/input/button.html');
@ -292,7 +291,7 @@ describe('Page.click', function () {
// This await should not hang.
await page.click('a');
});
itFailsFirefox('should click the button inside an iframe', async () => {
it('should click the button inside an iframe', async () => {
const { page, server } = getTestState();
await page.goto(server.EMPTY_PAGE);
@ -328,25 +327,20 @@ describe('Page.click', function () {
await frame.click('button');
expect(await frame.evaluate(() => globalThis.result)).toBe('Clicked');
});
itFailsFirefox(
'should click the button with deviceScaleFactor set',
async () => {
const { page, server } = getTestState();
it('should click the button with deviceScaleFactor set', async () => {
const { page, server } = getTestState();
await page.setViewport({ width: 400, height: 400, deviceScaleFactor: 5 });
expect(await page.evaluate(() => window.devicePixelRatio)).toBe(5);
await page.setContent(
'<div style="width:100px;height:100px">spacer</div>'
);
await utils.attachFrame(
page,
'button-test',
server.PREFIX + '/input/button.html'
);
const frame = page.frames()[1];
const button = await frame.$('button');
await button.click();
expect(await frame.evaluate(() => globalThis.result)).toBe('Clicked');
}
);
await page.setViewport({ width: 400, height: 400, deviceScaleFactor: 5 });
expect(await page.evaluate(() => window.devicePixelRatio)).toBe(5);
await page.setContent('<div style="width:100px;height:100px">spacer</div>');
await utils.attachFrame(
page,
'button-test',
server.PREFIX + '/input/button.html'
);
const frame = page.frames()[1];
const button = await frame.$('button');
await button.click();
expect(await frame.evaluate(() => globalThis.result)).toBe('Clicked');
});
});

2
test/elementhandle.spec.ts
View File

@ -258,7 +258,7 @@ describe('ElementHandle specs', function () {
});
describe('ElementHandle.hover', function () {
itFailsFirefox('should work', async () => {
it('should work', async () => {
const { page, server } = getTestState();
await page.goto(server.PREFIX + '/input/scrollable.html');

31
test/mouse.spec.ts
View File

@ -71,7 +71,7 @@ describe('Mouse', function () {
expect(event.isTrusted).toBe(true);
expect(event.button).toBe(0);
});
itFailsFirefox('should resize the textarea', async () => {
it('should resize the textarea', async () => {
const { page, server } = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
@ -87,7 +87,7 @@ describe('Mouse', function () {
expect(newDimensions.width).toBe(Math.round(width + 104));
expect(newDimensions.height).toBe(Math.round(height + 104));
});
itFailsFirefox('should select the text with mouse', async () => {
it('should select the text with mouse', async () => {
const { page, server } = getTestState();
await page.goto(server.PREFIX + '/input/textarea.html');
@ -220,23 +220,20 @@ describe('Mouse', function () {
]);
});
// @see https://crbug.com/929806
itFailsFirefox(
'should work with mobile viewports and cross process navigations',
async () => {
const { page, server } = getTestState();
it('should work with mobile viewports and cross process navigations', async () => {
const { page, server } = getTestState();
await page.goto(server.EMPTY_PAGE);
await page.setViewport({ width: 360, height: 640, isMobile: true });
await page.goto(server.CROSS_PROCESS_PREFIX + '/mobile.html');
await page.evaluate(() => {
document.addEventListener('click', (event) => {
globalThis.result = { x: event.clientX, y: event.clientY };
});
await page.goto(server.EMPTY_PAGE);
await page.setViewport({ width: 360, height: 640, isMobile: true });
await page.goto(server.CROSS_PROCESS_PREFIX + '/mobile.html');
await page.evaluate(() => {
document.addEventListener('click', (event) => {
globalThis.result = { x: event.clientX, y: event.clientY };
});
});
await page.mouse.click(30, 40);
await page.mouse.click(30, 40);
expect(await page.evaluate('result')).toEqual({ x: 30, y: 40 });
}
);
expect(await page.evaluate('result')).toEqual({ x: 30, y: 40 });
});
});