thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(typs): lints in puppeteer/docs (#11251)

Browse Source
This commit is contained in:
Abhishek Mallick 2023-10-27 21:17:47 +05:30 committed by GitHub
parent 8379f468f4
commit 4f999b3bf9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/contributing.md
View File

@ -57,7 +57,7 @@ npm run build --workspace <package> # e.g. puppeteer
```
This will build all dependent packages automatically, so specifying a single
packages is sufficient. This is all possible due to
package is sufficient. This is all possible due to
[wireit](https://github.com/google/wireit) which behaves similar to
[GNU Make](https://www.gnu.org/software/make/).

4
docs/troubleshooting.md
View File

@ -10,7 +10,7 @@ binaries for
## `Cannot find module 'puppeteer-core/internal/...'`
This can occur is your Node.js version is lower than 14 or you are using a
This can occur if your Node.js version is lower than 14 or if you are using a
custom resolver (such as
[`jest-resolve`](https://www.npmjs.com/package/jest-resolve)). For the former,
we do not support deprecated versions of Node.js. For the latter, usually
@ -456,7 +456,7 @@ Error: Failed to launch chrome! spawn /usr/bin/chromium-browser ENOENT
You need to patch two places:
1. Your `gitlab-ci.yml` config
2. Arguments' list when launching pupepeteer
2. Arguments' list when launching puppeteer
In `gitlab-ci.yml` we need to install some packages to make it possible to
launch headless Chrome in your docker env: