thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: enable screencast for BiDi+ (#11171)

Browse Source
This commit is contained in:
Nikolay Vitkov 2023-10-16 13:54:10 +02:00 committed by GitHub
parent 8dc3969bc2
commit 511614fe44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/puppeteer-core/src/bidi/Browser.ts
View File

@ -73,6 +73,7 @@ export class BidiBrowser extends Browser {
// TODO: subscribe to all CDP events in the future. // TODO: subscribe to all CDP events in the future.
'cdp.Network.requestWillBeSent', 'cdp.Network.requestWillBeSent',
'cdp.Debugger.scriptParsed', 'cdp.Debugger.scriptParsed',
'cdp.Page.screencastFrame',
]; ];
static async create(opts: BidiBrowserOptions): Promise<BidiBrowser> { static async create(opts: BidiBrowserOptions): Promise<BidiBrowser> {

8
test/TestExpectations.json
View File

@ -1205,6 +1205,12 @@
"parameters": ["cdp", "firefox"], "parameters": ["cdp", "firefox"],
"expectations": ["FAIL", "SKIP"] "expectations": ["FAIL", "SKIP"]
}, },
{
"testIdPattern": "[screencast.spec] *",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome", "webDriverBiDi"],
"expectations": ["PASS"]
},
{ {
"testIdPattern": "[screencast.spec] Screencasts Page.screencast should validate options", "testIdPattern": "[screencast.spec] Screencasts Page.screencast should validate options",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
@ -3327,7 +3333,7 @@
"testIdPattern": "[prerender.spec] Prerender can screencast", "testIdPattern": "[prerender.spec] Prerender can screencast",
"platforms": ["darwin", "linux", "win32"], "platforms": ["darwin", "linux", "win32"],
"parameters": ["chrome", "webDriverBiDi"], "parameters": ["chrome", "webDriverBiDi"],
"expectations": ["TIMEOUT"] "expectations": ["PASS"]
}, },
{ {
"testIdPattern": "[proxy.spec] request proxy in incognito browser context should proxy requests when configured at browser level", "testIdPattern": "[proxy.spec] request proxy in incognito browser context should proxy requests when configured at browser level",