thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: fix doclint issues (#5784)

Browse Source
This commit is contained in:
Mathias Bynens 2020-04-30 12:58:51 +02:00 committed by GitHub
parent 32c8c6992c
commit 541281b9f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CONTRIBUTING.md
View File

@ -4,6 +4,7 @@
* [Getting Code](#getting-code) * [Getting Code](#getting-code)
* [Code reviews](#code-reviews) * [Code reviews](#code-reviews)
* [Code Style](#code-style) * [Code Style](#code-style)
* [TypeScript guidelines](#typescript-guidelines)
* [API guidelines](#api-guidelines) * [API guidelines](#api-guidelines)
* [Commit Messages](#commit-messages) * [Commit Messages](#commit-messages)
* [Writing Documentation](#writing-documentation) * [Writing Documentation](#writing-documentation)

2
utils/doclint/check_public_api/JSBuilder.js
View File

@ -189,7 +189,7 @@ function checkSources(sources) {
* @return {boolean} * @return {boolean}
*/ */
function symbolHasPrivateModifier(symbol) { function symbolHasPrivateModifier(symbol) {
const modifiers = symbol.valueDeclaration.modifiers || []; const modifiers = symbol.valueDeclaration && symbol.valueDeclaration.modifiers || [];
return modifiers.some(modifier => modifier.kind === ts.SyntaxKind.PrivateKeyword); return modifiers.some(modifier => modifier.kind === ts.SyntaxKind.PrivateKeyword);
} }