From 5885792be462f4e58276e2813c155c45e979f97b Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Wed, 19 Oct 2022 16:24:56 +0200 Subject: [PATCH] chore: re-enable firefox on mac (#9137) I believe they were previously enabled but got disabled with the recent changes. Let's re-enable it as they don't appear to be slower than the chrome tests. --- .github/workflows/ci.yml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e6543c5f..75e74f52 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -156,11 +156,14 @@ jobs: run: xvfb-run --auto-servernum npm run test -- --test-suite ${{ matrix.suite }} firefox-tests: - name: ${{ matrix.suite }} tests on ubuntu-latest - runs-on: ubuntu-latest + name: ${{ matrix.suite }} tests on ${{ matrix.os }} + runs-on: ${{ matrix.os }} strategy: fail-fast: false matrix: + os: + - ubuntu-latest + - macos-latest suite: - firefox-bidi - firefox-headful @@ -187,10 +190,15 @@ jobs: PUPPETEER_PRODUCT: firefox run: npm run postinstall - name: Install linux dependencies. + if: ${{ matrix.os == 'ubuntu-latest' }} run: sudo apt-get install xvfb - name: Tests types run: npm run test-types - - name: Run all tests + - name: Run all tests (for non-Linux) + if: ${{ matrix.os != 'ubuntu-latest' }} + run: npm run test -- --test-suite ${{ matrix.suite }} + - name: Run all tests (for Linux) + if: ${{ matrix.os == 'ubuntu-latest' }} run: xvfb-run --auto-servernum npm run test -- --test-suite ${{ matrix.suite }} installation-test-build: