diff --git a/test/TestExpectations.json b/test/TestExpectations.json index a62bf742..13913b4e 100644 --- a/test/TestExpectations.json +++ b/test/TestExpectations.json @@ -3989,18 +3989,6 @@ "parameters": ["cdp", "chrome", "new-headless"], "expectations": ["FAIL", "PASS"] }, - { - "testIdPattern": "[fixtures.spec] Fixtures dumpio option should work with pipe option", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["cdp", "chrome", "headful"], - "expectations": ["FAIL", "PASS"] - }, - { - "testIdPattern": "[fixtures.spec] Fixtures dumpio option should work with pipe option", - "platforms": ["darwin", "linux", "win32"], - "parameters": ["cdp", "chrome", "new-headless"], - "expectations": ["FAIL", "PASS"] - }, { "testIdPattern": "[headful.spec] headful tests HEADFUL OOPIF: should expose events within OOPIFs", "platforms": ["linux"], diff --git a/test/src/fixtures.spec.ts b/test/src/fixtures.spec.ts index d8204272..809f7c32 100644 --- a/test/src/fixtures.spec.ts +++ b/test/src/fixtures.spec.ts @@ -29,7 +29,7 @@ describe('Fixtures', function () { it('dumpio option should work with pipe option', async () => { const {defaultBrowserOptions, puppeteerPath, headless} = await getTestState(); - if (headless === 'new') { + if (headless !== 'true') { // This test only works in the old headless mode. return; } @@ -46,7 +46,7 @@ describe('Fixtures', function () { JSON.stringify(options), ]); res.stderr.on('data', data => { - return (dumpioData += data.toString('utf8')); + dumpioData += data.toString('utf8'); }); await new Promise(resolve => { return res.on('close', resolve); @@ -65,7 +65,7 @@ describe('Fixtures', function () { JSON.stringify(options), ]); res.stderr.on('data', data => { - return (dumpioData += data.toString('utf8')); + dumpioData += data.toString('utf8'); }); await new Promise(resolve => { return res.on('close', resolve); @@ -88,7 +88,7 @@ describe('Fixtures', function () { ]); let wsEndPointCallback: (value: string) => void; const wsEndPointPromise = new Promise(x => { - return (wsEndPointCallback = x); + wsEndPointCallback = x; }); let output = ''; res.stdout.on('data', data => { @@ -103,7 +103,7 @@ describe('Fixtures', function () { const promises = [ waitEvent(browser, 'disconnected'), new Promise(resolve => { - return res.on('close', resolve); + res.on('close', resolve); }), ]; if (process.platform === 'win32') {