fix(executioncontext): follow up to properly adopt element handles (#3857)

The `executionContextId` argument was missing, which made all
element handles to resolve in the main world. All our tests pass
atm, but this would've fired back when we exposed extension
execution contexts.
This commit is contained in:
Andrey Lushnikov 2019-01-28 14:20:28 -08:00 committed by GitHub
parent 55432f88e9
commit 63d9ac4df8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -186,6 +186,7 @@ class ExecutionContext {
});
const {object} = await this._client.send('DOM.resolveNode', {
backendNodeId: nodeInfo.node.backendNodeId,
executionContextId: this._contextId,
});
return /** @type {Puppeteer.ElementHandle}*/(createJSHandle(this, object));
}