thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: mark launcher spec as failing on Windows (#6574)

Browse Source 
We've pushed this date back a lot, let's make it permanent until we have
more time to investigate.
This commit is contained in:
Jack Franklin 2020-11-03 10:11:29 +00:00 committed by GitHub
parent 3bb417b14b
commit 659193a4f5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
test/launcher.spec.ts
View File

@ -22,7 +22,7 @@ import {
getTestState, getTestState,
itFailsFirefox, itFailsFirefox,
itOnlyRegularInstall, itOnlyRegularInstall,
itFailsWindowsUntilDate, itFailsWindows,
} from './mocha-utils'; // eslint-disable-line import/extensions } from './mocha-utils'; // eslint-disable-line import/extensions
import utils from './utils.js'; import utils from './utils.js';
import expect from 'expect'; import expect from 'expect';
@ -471,22 +471,17 @@ describe('Launcher specs', function () {
}); });
/* We think there's a bug in the FF Windows launcher, or some /* We think there's a bug in the FF Windows launcher, or some
* combo of that plus it running on CI, but we're deferring fixing * combo of that plus it running on CI, but it's hard to track down.
* this so we can get Windows CI stable and then dig into this * See comment here: https://github.com/puppeteer/puppeteer/issues/5673#issuecomment-670141377.
* properly with help from the Mozilla folks.
*/ */
itFailsWindowsUntilDate( itFailsWindows('should be able to launch Firefox', async function () {
new Date('2020-10-31'), this.timeout(FIREFOX_TIMEOUT);
'should be able to launch Firefox', const { puppeteer } = getTestState();
async function () { const browser = await puppeteer.launch({ product: 'firefox' });
this.timeout(FIREFOX_TIMEOUT); const userAgent = await browser.userAgent();
const { puppeteer } = getTestState(); await browser.close();
const browser = await puppeteer.launch({ product: 'firefox' }); expect(userAgent).toContain('Firefox');
const userAgent = await browser.userAgent(); });
await browser.close();
expect(userAgent).toContain('Firefox');
}
);
}); });
describe('Puppeteer.connect', function () { describe('Puppeteer.connect', function () {