thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs(troubleshooting): fix docker example (#3743)

Browse Source 
* removing libgconf-2-4 install since no longer needed according to https://bugs.chromium.org/p/chromium/issues/detail?id=795759#c7
* wget is already included in `node:8-slim` image, so removed lines related to install/cleanup
* node 8 has EOL this year, so incremented to node:10-slim
* use "docker run --init" if available (available in docker-engine >= 1.13.0)
* make dumb-init optional
* combine permission changes and 'npm install' of puppeteer into same line to reduce image size by few hundred MB
* overall image size reduction: 1.21GB -> 865MB
This commit is contained in:
Neil Halelamien 2019-04-02 19:30:23 -07:00 committed by Andrey Lushnikov
parent 66ff4928eb
commit 695b30a425
1 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
docs/troubleshooting.md
View File

@ -203,27 +203,24 @@ To fix, you'll need to install the missing dependencies and the
latest Chromium package in your Dockerfile: latest Chromium package in your Dockerfile:
```Dockerfile ```Dockerfile
FROM node:8-slim FROM node:10-slim
# See https://crbug.com/795759
RUN apt-get update && apt-get install -yq libgconf-2-4
# Install latest chrome dev package and fonts to support major charsets (Chinese, Japanese, Arabic, Hebrew, Thai and a few others) # Install latest chrome dev package and fonts to support major charsets (Chinese, Japanese, Arabic, Hebrew, Thai and a few others)
# Note: this installs the necessary libs to make the bundled version of Chromium that Puppeteer # Note: this installs the necessary libs to make the bundled version of Chromium that Puppeteer
# installs, work. # installs, work.
RUN apt-get update && apt-get install -y wget --no-install-recommends \ RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - \
&& wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - \
&& sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list' \ && sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list' \
&& apt-get update \ && apt-get update \
&& apt-get install -y google-chrome-unstable fonts-ipafont-gothic fonts-wqy-zenhei fonts-thai-tlwg fonts-kacst ttf-freefont \ && apt-get install -y google-chrome-unstable fonts-ipafont-gothic fonts-wqy-zenhei fonts-thai-tlwg fonts-kacst ttf-freefont \
--no-install-recommends \ --no-install-recommends \
&& rm -rf /var/lib/apt/lists/* \ && rm -rf /var/lib/apt/lists/* \
&& apt-get purge --auto-remove -y curl \
&& rm -rf /src/*.deb && rm -rf /src/*.deb
# It's a good idea to use dumb-init to help prevent zombie chrome processes. # If running Docker >= 1.13.0 use docker run's --init arg to reap zombie processes, otherwise
ADD https://github.com/Yelp/dumb-init/releases/download/v1.2.0/dumb-init_1.2.0_amd64 /usr/local/bin/dumb-init # uncomment the following lines to have `dumb-init` as PID 1
RUN chmod +x /usr/local/bin/dumb-init # ADD https://github.com/Yelp/dumb-init/releases/download/v1.2.0/dumb-init_1.2.0_amd64 /usr/local/bin/dumb-init
# RUN chmod +x /usr/local/bin/dumb-init
# ENTRYPOINT ["dumb-init", "--"]
# Uncomment to skip the chromium download when installing puppeteer. If you do, # Uncomment to skip the chromium download when installing puppeteer. If you do,
# you'll need to launch puppeteer with: # you'll need to launch puppeteer with:
@ -231,10 +228,10 @@ RUN chmod +x /usr/local/bin/dumb-init
# ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true # ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true
# Install puppeteer so it's available in the container. # Install puppeteer so it's available in the container.
RUN npm i puppeteer RUN npm i puppeteer \
# Add user so we don't need --no-sandbox.
# Add user so we don't need --no-sandbox. # same layer as npm install to keep re-chowned files from using up several hundred MBs more space
RUN groupadd -r pptruser && useradd -r -g pptruser -G audio,video pptruser \ && groupadd -r pptruser && useradd -r -g pptruser -G audio,video pptruser \
&& mkdir -p /home/pptruser/Downloads \ && mkdir -p /home/pptruser/Downloads \
&& chown -R pptruser:pptruser /home/pptruser \ && chown -R pptruser:pptruser /home/pptruser \
&& chown -R pptruser:pptruser /node_modules && chown -R pptruser:pptruser /node_modules
@ -242,7 +239,6 @@ RUN groupadd -r pptruser && useradd -r -g pptruser -G audio,video pptruser \
# Run everything after as non-privileged user. # Run everything after as non-privileged user.
USER pptruser USER pptruser
ENTRYPOINT ["dumb-init", "--"]
CMD ["google-chrome-unstable"] CMD ["google-chrome-unstable"]
``` ```
@ -255,7 +251,7 @@ docker build -t puppeteer-chrome-linux .
Run the container by passing `node -e "<yourscript.js content as a string>` as the command: Run the container by passing `node -e "<yourscript.js content as a string>` as the command:
```bash ```bash
docker run -i --rm --cap-add=SYS_ADMIN \ docker run -i --init --rm --cap-add=SYS_ADMIN \
--name puppeteer-chrome puppeteer-chrome-linux \ --name puppeteer-chrome puppeteer-chrome-linux \
node -e "`cat yourscript.js`" node -e "`cat yourscript.js`"
``` ```