thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(connection): separate send/receive debug logging (#6017)

Browse Source 
This PR splits the logging for send and receive messages in to separate debug channels.
This way it is easier to filter and takes advantage of debug's automated coloring to make
it easier to visually parse on the command line
This commit is contained in:
Jarrod Overson 2020-06-15 04:36:45 -04:00 committed by GitHub
parent c701ea194a
commit 6e060ce0fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Connection.ts
View File

@ -16,7 +16,8 @@
import { assert } from './helper'; import { assert } from './helper';
import { Events } from './Events'; import { Events } from './Events';
import * as debug from 'debug'; import * as debug from 'debug';
const debugProtocol = debug('puppeteer:protocol'); const debugProtocolSend = debug('puppeteer:protocol:SEND ►');
const debugProtocolReceive = debug('puppeteer:protocol:RECV ◀');
import Protocol from './protocol'; import Protocol from './protocol';
import { ConnectionTransport } from './ConnectionTransport'; import { ConnectionTransport } from './ConnectionTransport';
@ -78,14 +79,14 @@ export class Connection extends EventEmitter {
_rawSend(message: {}): number { _rawSend(message: {}): number {
const id = ++this._lastId; const id = ++this._lastId;
message = JSON.stringify(Object.assign({}, message, { id })); message = JSON.stringify(Object.assign({}, message, { id }));
debugProtocol('SEND ► ' + message); debugProtocolSend(message);
this._transport.send(message); this._transport.send(message);
return id; return id;
} }
async _onMessage(message: string): Promise<void> { async _onMessage(message: string): Promise<void> {
if (this._delay) await new Promise((f) => setTimeout(f, this._delay)); if (this._delay) await new Promise((f) => setTimeout(f, this._delay));
debugProtocol('◀ RECV ' + message); debugProtocolReceive(message);
const object = JSON.parse(message); const object = JSON.parse(message);
if (object.method === 'Target.attachedToTarget') { if (object.method === 'Target.attachedToTarget') {
const sessionId = object.params.sessionId; const sessionId = object.params.sessionId;