thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(queryhandler) only expose custom handlers (#6475)

Browse Source 
This commit changes the custom query handler API to only operate on user-defined query handlers.
This commit is contained in:
Johan Bay 2020-10-07 10:15:54 +02:00 committed by GitHub
parent 950ae334ca
commit 70ed875158
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/common/QueryHandler.ts
View File

@ -101,11 +101,8 @@ const _defaultHandler = makeQueryHandler({
element.querySelectorAll(selector), element.querySelectorAll(selector),
}); });
const _builtInHandlers: Array<[string, InternalQueryHandler]> = [ const _builtInHandlers = new Map([['aria', ariaHandler]]);
['aria', ariaHandler], const _queryHandlers = new Map(_builtInHandlers);
];
const _queryHandlers = new Map<string, InternalQueryHandler>(_builtInHandlers);
export function registerCustomQueryHandler( export function registerCustomQueryHandler(
name: string, name: string,
@ -127,17 +124,19 @@ export function registerCustomQueryHandler(
* @param {string} name * @param {string} name
*/ */
export function unregisterCustomQueryHandler(name: string): void { export function unregisterCustomQueryHandler(name: string): void {
if (_queryHandlers.has(name)) { if (_queryHandlers.has(name) && !_builtInHandlers.has(name)) {
_queryHandlers.delete(name); _queryHandlers.delete(name);
} }
} }
export function customQueryHandlerNames(): string[] { export function customQueryHandlerNames(): string[] {
return [..._queryHandlers.keys()]; return [..._queryHandlers.keys()].filter(
(name) => !_builtInHandlers.has(name)
);
} }
export function clearCustomQueryHandlers(): void { export function clearCustomQueryHandlers(): void {
_queryHandlers.clear(); customQueryHandlerNames().forEach(unregisterCustomQueryHandler);
} }
export function getQueryHandlerAndSelector( export function getQueryHandlerAndSelector(