From 71cc1b95910c5fd9291245b189a043a1cc23b25c Mon Sep 17 00:00:00 2001
From: Ben Allfree <ben@benallfree.com>
Date: Thu, 9 Dec 2021 06:35:23 -0800
Subject: [PATCH] refactor: remove unused promise (#7830)

---
 src/common/NetworkEventManager.ts |  2 --
 src/common/NetworkManager.ts      | 20 +-------------------
 2 files changed, 1 insertion(+), 21 deletions(-)

diff --git a/src/common/NetworkEventManager.ts b/src/common/NetworkEventManager.ts
index 70d9ac3c..aa8e1adc 100644
--- a/src/common/NetworkEventManager.ts
+++ b/src/common/NetworkEventManager.ts
@@ -3,8 +3,6 @@ import { HTTPRequest } from './HTTPRequest.js';
 
 export type QueuedEventGroup = {
   responseReceivedEvent: Protocol.Network.ResponseReceivedEvent;
-  promise: Promise<void>;
-  resolver: () => void;
   loadingFinishedEvent?: Protocol.Network.LoadingFinishedEvent;
   loadingFailedEvent?: Protocol.Network.LoadingFailedEvent;
 };
diff --git a/src/common/NetworkManager.ts b/src/common/NetworkManager.ts
index b825331c..d1d99d27 100644
--- a/src/common/NetworkManager.ts
+++ b/src/common/NetworkManager.ts
@@ -22,11 +22,7 @@ import { helper, debugError } from './helper.js';
 import { Protocol } from 'devtools-protocol';
 import { HTTPRequest } from './HTTPRequest.js';
 import { HTTPResponse } from './HTTPResponse.js';
-import {
-  FetchRequestId,
-  NetworkEventManager,
-  NetworkRequestId,
-} from './NetworkEventManager.js';
+import { FetchRequestId, NetworkEventManager } from './NetworkEventManager.js';
 
 /**
  * @public
@@ -480,12 +476,8 @@ export class NetworkManager extends EventEmitter {
         .shift();
       if (!extraInfo) {
         // Wait until we get the corresponding ExtraInfo event.
-        let resolver = null;
-        const promise = new Promise<void>((resolve) => (resolver = resolve));
         this._networkEventManager.queueEventGroup(event.requestId, {
           responseReceivedEvent: event,
-          promise,
-          resolver,
         });
         return;
       }
@@ -493,15 +485,6 @@ export class NetworkManager extends EventEmitter {
     this._emitResponseEvent(event, extraInfo);
   }
 
-  responseWaitingForExtraInfoPromise(
-    networkRequestId: NetworkRequestId
-  ): Promise<void> {
-    const responseReceived =
-      this._networkEventManager.getQueuedEventGroup(networkRequestId);
-    if (!responseReceived) return Promise.resolve();
-    return responseReceived.promise;
-  }
-
   _onResponseReceivedExtraInfo(
     event: Protocol.Network.ResponseReceivedExtraInfoEvent
   ): void {
@@ -530,7 +513,6 @@ export class NetworkManager extends EventEmitter {
       if (queuedEvents.loadingFailedEvent) {
         this._emitLoadingFailed(queuedEvents.loadingFailedEvent);
       }
-      queuedEvents.resolver();
       return;
     }