thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: remove unused tracing category for cpu profiling (#5866)

Browse Source
This commit is contained in:
Peter Marshall 2021-09-15 19:59:38 +10:00 committed by GitHub
parent 201557f722
commit 726cb14003
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/common/Tracing.ts
View File

@ -77,7 +77,6 @@ export class Tracing {
'latencyInfo', 'latencyInfo',
'disabled-by-default-devtools.timeline.stack', 'disabled-by-default-devtools.timeline.stack',
'disabled-by-default-v8.cpu_profiler', 'disabled-by-default-v8.cpu_profiler',
'disabled-by-default-v8.cpu_profiler.hires',
]; ];
const { const {
path = null, path = null,

4
test/tracing.spec.ts
View File

@ -56,7 +56,7 @@ describeChromeOnly('Tracing', function () {
it('should run with custom categories if provided', async () => { it('should run with custom categories if provided', async () => {
await page.tracing.start({ await page.tracing.start({
path: outputFile, path: outputFile,
categories: ['-*', 'disabled-by-default-v8.cpu_profiler.hires'], categories: ['-*', 'disabled-by-default-devtools.timeline.frame'],
}); });
await page.tracing.stop(); await page.tracing.stop();
@ -65,7 +65,7 @@ describeChromeOnly('Tracing', function () {
); );
const traceConfig = JSON.parse(traceJson.metadata['trace-config']); const traceConfig = JSON.parse(traceJson.metadata['trace-config']);
expect(traceConfig.included_categories).toEqual([ expect(traceConfig.included_categories).toEqual([
'disabled-by-default-v8.cpu_profiler.hires', 'disabled-by-default-devtools.timeline.frame',
]); ]);
expect(traceConfig.excluded_categories).toEqual(['*']); expect(traceConfig.excluded_categories).toEqual(['*']);
expect(traceJson.traceEvents).not.toContainEqual( expect(traceJson.traceEvents).not.toContainEqual(