chore: include component in puppeteer tag (#9303)

Removes `include-component-in-tag` from the release please config which
means that Puppeteer package releases will now be following the format
`puppeteer-vX.X.X`. Also, this PR updates the docker publishing action
to correctly parse such a tag to extract the `X.X.X` part, that is to be
used as the docker image label.
This commit is contained in:
Alex Rudenko 2022-11-23 12:48:14 +01:00 committed by GitHub
parent eda182741b
commit 750f236f0c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 11 deletions

View File

@ -21,21 +21,14 @@ jobs:
run: npm run build run: npm run build
- name: Set npm registry - name: Set npm registry
run: npm config set registry 'https://wombat-dressing-room.appspot.com/' run: npm config set registry 'https://wombat-dressing-room.appspot.com/'
- name: Publish Puppeteer
if: ${{ startsWith(github.ref_name, 'v') }}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN_PUPPETEER}}
run: |
npm config set '//wombat-dressing-room.appspot.com/:_authToken' $NODE_AUTH_TOKEN
npm publish --workspace packages/puppeteer
- name: Publish packages - name: Publish packages
if: ${{ !startsWith(github.ref_name, 'v') }}
env: env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN_RELEASE}} NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN_RELEASE}}
run: | run: |
npm config set '//wombat-dressing-room.appspot.com/:_authToken' $NODE_AUTH_TOKEN npm config set '//wombat-dressing-room.appspot.com/:_authToken' $NODE_AUTH_TOKEN
npm publish --workspace packages/${GITHUB_REF_NAME%-v*} npm publish --workspace packages/${GITHUB_REF_NAME%-v*}
- name: Deprecate old versions - name: Deprecate old versions
if: ${{ startsWith(github.ref_name, 'puppeteer-v') }}
run: | run: |
version_range=$(node tools/get_deprecated_version_range.js) version_range=$(node tools/get_deprecated_version_range.js)
npm deprecate puppeteer@"$version_range" "$version_range is no longer supported" npm deprecate puppeteer@"$version_range" "$version_range is no longer supported"
@ -43,7 +36,7 @@ jobs:
docker-publish: docker-publish:
name: Publish Docker image name: Publish Docker image
runs-on: ubuntu-latest runs-on: ubuntu-latest
if: ${{ startsWith(github.ref_name, 'v') }} if: ${{ startsWith(github.ref_name, 'puppeteer-v') }}
permissions: permissions:
contents: read contents: read
packages: write packages: write
@ -73,7 +66,7 @@ jobs:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
tags: | tags: |
latest latest
type=semver,pattern={{version}} type=match,pattern=puppeteer-v(\d+\.\d+\.\d+),group=1
- name: Build and push the Docker image - name: Build and push the Docker image
uses: docker/build-push-action@c84f38281176d4c9cdb1626ffafcd6b3911b5d94 uses: docker/build-push-action@c84f38281176d4c9cdb1626ffafcd6b3911b5d94
with: with:

View File

@ -2,7 +2,6 @@
"last-release-sha": "2e3719cd7fbab551e99625bfb6198183aa23e7f5", "last-release-sha": "2e3719cd7fbab551e99625bfb6198183aa23e7f5",
"packages": { "packages": {
"packages/puppeteer": { "packages/puppeteer": {
"include-component-in-tag": false,
"component": "puppeteer" "component": "puppeteer"
}, },
"packages/puppeteer-core": { "packages/puppeteer-core": {