thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(Chromium): roll Chromium to r510398 (#1112)

Browse Source 
This roll includes revision https://crrev.com/510285 that fixes
the clipping bug on retina displays.

Fixes #733
This commit is contained in:
Andrey Lushnikov 2017-10-20 10:58:39 -07:00 committed by GitHub
parent 5c92ba222a
commit 7f60e33a63
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -34,7 +34,7 @@
"ws": "^3.0.0" "ws": "^3.0.0"
}, },
"puppeteer": { "puppeteer": {
"chromium_revision": "510141" "chromium_revision": "510398"
}, },
"devDependencies": { "devDependencies": {
"@types/debug": "0.0.30", "@types/debug": "0.0.30",

4
test/test.js
View File

@ -2531,9 +2531,7 @@ describe('Page', function() {
const screenshot = await page.screenshot({omitBackground: true}); const screenshot = await page.screenshot({omitBackground: true});
expect(screenshot).toBeGolden('transparent.png'); expect(screenshot).toBeGolden('transparent.png');
})); }));
// Doesn't work on retina displays. it('should work with odd clip size on Retina displays', SX(async function() {
// @see https://github.com/GoogleChrome/puppeteer/issues/733
xit('should work with odd clip size on Retina displays', SX(async function() {
const screenshot = await page.screenshot({ const screenshot = await page.screenshot({
clip: { clip: {
x: 0, x: 0,