thunderstrike/puppeteer
thunderstrike/puppeteer
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: clarify node_js versions in Travis config (#6570)

Browse Source 
This patch makes it so that we only refer to specific Node.js versions like `10.19.0` when we really mean to use exactly that version. Usually we just want to test the latest version in a major range, e.g. `10`.

It also adds an inline comment that makes it easier to update the versions across the file in the future (e.g. when Node.js 10 goes EOL in April 2021).

Issue: #6561
This commit is contained in:
Mathias Bynens 2020-11-04 12:45:52 +01:00 committed by GitHub
parent 6d4f0a3d06
commit 8c98315f40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
.travis.yml
View File

@ -1,11 +1,17 @@
language: node_js language: node_js
services: xvfb services: xvfb
# Throughout this file, the following `node_js` versions are being used:
#
# - node_js: '10' # The maintenance LTS version.
# - node_js: '12' # The oldest major active LTS version.
# - node_js: '14' # The newest major active LTS version.
jobs: jobs:
include: include:
- os: 'osx' - os: 'osx'
name: 'Unit tests: macOS/Chromium' name: 'Unit tests: macOS/Chromium'
node_js: '10.19.0' node_js: '10' # The maintenance LTS version.
osx_image: xcode11.4 osx_image: xcode11.4
env: env:
- CHROMIUM=true - CHROMIUM=true
@ -18,7 +24,7 @@ jobs:
- os: 'windows' - os: 'windows'
name: 'Unit tests: Windows/Chromium' name: 'Unit tests: Windows/Chromium'
node_js: '10.19.0' node_js: '10' # The maintenance LTS version.
env: env:
- CHROMIUM=true - CHROMIUM=true
before_install: before_install:
@ -42,7 +48,7 @@ jobs:
script: script:
- npm run unit - npm run unit
- node_js: '10.19.0' - node_js: '10' # The maintenance LTS version.
name: 'Unit tests [with coverage]: Linux/Chromium' name: 'Unit tests [with coverage]: Linux/Chromium'
env: env:
- CHROMIUM=true - CHROMIUM=true
@ -52,7 +58,7 @@ jobs:
- travis_retry npm run unit-with-coverage - travis_retry npm run unit-with-coverage
- npm run assert-unit-coverage - npm run assert-unit-coverage
- node_js: '12.16.3' - node_js: '12' # The oldest major active LTS version.
name: 'Unit tests [Node 12]: Linux/Chromium' name: 'Unit tests [Node 12]: Linux/Chromium'
env: env:
- CHROMIUM=true - CHROMIUM=true
@ -61,7 +67,7 @@ jobs:
script: script:
- npm run unit - npm run unit
- node_js: '14.2.0' - node_js: '14' # The newest major active LTS version.
name: 'Unit tests [Node 14]: Linux/Chromium' name: 'Unit tests [Node 14]: Linux/Chromium'
env: env:
- CHROMIUM=true - CHROMIUM=true
@ -70,7 +76,7 @@ jobs:
script: script:
- npm run unit - npm run unit
- node_js: '12.16.3' - node_js: '12' # The oldest major active LTS version.
name: 'Browser tests: Linux/Chromium' name: 'Browser tests: Linux/Chromium'
addons: addons:
chrome: stable chrome: stable
@ -79,8 +85,8 @@ jobs:
script: script:
- npm run test-browser - npm run test-browser
# This bot runs all the extra checks that aren't the main Puppeteer unit tests # This bot runs all the extra checks that aren't the main Puppeteer unit tests.
- node_js: '10.19.0' - node_js: '10' # The maintenance LTS version.
name: 'Extra tests: Linux/Chromium' name: 'Extra tests: Linux/Chromium'
env: env:
- CHROMIUM=true - CHROMIUM=true
@ -92,15 +98,14 @@ jobs:
# This bot runs separately as it changes package.json to test puppeteer-core # This bot runs separately as it changes package.json to test puppeteer-core
# and we don't want that leaking into other bots and causing issues. # and we don't want that leaking into other bots and causing issues.
- node_js: '10.19.0' - node_js: '10' # The maintenance LTS version.
name: 'Test bundling and install of packages' name: 'Test bundling and install of packages'
env: env:
- CHROMIUM=true - CHROMIUM=true
script: script:
- npm run test-install - npm run test-install
# Runs unit tests on Linux + Firefox - node_js: '10' # The maintenance LTS version.
- node_js: '10.19.0'
name: 'Unit tests: Linux/Firefox' name: 'Unit tests: Linux/Firefox'
env: env:
- FIREFOX=true - FIREFOX=true